[PWGHF] First draft of Omegac0 to OmegaPi QA workflow - #18126
Draft
mtorresc15 wants to merge 13 commits into
Draft
mtorresc15 wants to merge 13 commits into
mtorresc15 wants to merge 13 commits into
Conversation
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new executables lack build registration, and selector issues can alter cuts or fatally terminate ML workflows.
Review effort: Balanced
Findings: 4
Open (7)
What changed in this PR
Adds QA workflows for comparing DCAFitter and KFParticle Ωc⁰→Ωπ reconstruction.
Changes:
- Adds QA candidate selection and output trees.
- Adds reconstruction-specific ML features.
- Adds data/MC analysis modes with optional ML and centrality.
| File | Description |
|---|---|
PWGHF/TableProducer/treeCreatorOmegac0ToOmegaPiQa.cxx |
Defines detailed QA output tables. |
PWGHF/TableProducer/candidateSelectorOmegac0ToOmegaPiQa.cxx |
Implements selection, PID, ML, and QA monitoring. |
PWGHF/D2H/Tasks/taskOmegac0ToOmegaPiQa.cxx |
Adds data and MC analysis modes. |
PWGHF/Core/HfMlResponseOmegacToOmegaPiQa.h |
Defines DCAFitter and KFParticle ML features. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| if constexpr (svReco == doKfParticle) { | ||
| inputFeaturesOmegaC = hfMlResponseKf.getInputFeatures(candidate, trackPiFromLam, trackKaFromCasc, trackPiFromCharm); | ||
| isSelectedMlOmegac = hfMlResponseKf.isSelectedMl(inputFeaturesOmegaC, ptCandOmegac, outputMlOmegac); |
| registry.fill(HIST("hSelStatusLf"), 14.0); | ||
|
|
||
| // Chi2 | ||
| if (candidate.chi2GeoV0() < 0 || candidate.chi2GeoV0() > kfConfigurableGroup.v0Chi2OverNdfMax) { |
|
|
||
| // pT: Charm Bachelor | ||
| double ptPiFromCharmBaryon = RecoDecay::sqrtSumOfSquares(candidate.pxBachFromCharmBaryon(), candidate.pyBachFromCharmBaryon()); | ||
| if (ptPiFromCharmBaryon < ptPiFromCharmBaryonMin) { |
| // or submit itself to any jurisdiction. | ||
|
|
||
| /// \file HfMlResponseOmegacToOmegaPiQa.h | ||
| /// \brief Class to compute the ML response for Ωc± → Ω∓ π± analysis selections |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First draft of the QA workflow for the Omegac0 to OmegaPi analysis.
This PR introduces dedicated QA versions of the candidate selector, tree creator, analysis task, and ML response to allow a more detailed validation of the Omegac0 to OmegaPi analysis workflow.
The main additions are:
The implementation is based on the existing Omegac0 to OmegaPi analysis workflow and is intended to facilitate validation and comparison of the DCAFitter and KFParticle reconstruction and selection strategies.
This PR is opened as a draft for preliminary review and feedback.