Repository navigation
Conversation
Data providers for folder normalization, the paths a folder holds, the root URL without the folder, the folder's shape and the reserved panel prefixes; tests for the one address per site rule, the default site at the root, and that a request into a folder leaves nothing behind. Bitrix: the default site is moved and listed first. Mutation score of the changed lines is 100%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sites in folders (`example.com/site2/`) are already in main (225dcca). This adds the tests the new rule asks for: every changed line covered, every condition both ways, and a test that goes red when the line is broken.
Checked with `bin/ci`: lint, PHPStan, PHPUnit on SQLite, MySQL and PostgreSQL, coverage (changed lines 100%) and mutation (MSI 100% on the changed lines of admin and bitrix), Dusk. The only red leg here is PostgreSQL for the backup package: this machine has no `pg_dump`; the package is untouched.