[Amanbig]

Problem (data-loss bug in the tests, from March)

tests/test_integration.py creates Permissions() and calls set_tool_permission("filesystem"|"edit", ALLOW). That method saves, and the target path is a module constant evaluated from Path.home() at import time, so every pytest run on a developer machine overwrote the real ~/.devorch/permissions.yaml with exactly:

tools:
  edit: {level: allow}
  filesystem: {level: allow}

Consequences: any saved rules ("always allow" patterns, deny rules, per-tool levels) were silently replaced, and DevOrch then edited and wrote files without asking in ASK mode. A stray DevOrch session run by the maintainer did exactly that and modified cli/main.py. The suite also wrote ~/.devorch/sessions/registry.json.

Found by running the suite with HOME pointed at an empty directory (only test_integration.py produced permissions.yaml) and bisecting by file.

Fix

New tests/conftest.py, executed before any application module is imported:

• HOME / USERPROFILE point at a throwaway temp dir (removed at session end), so every Path.home() / ".devorch" constant resolves there
• PYTHON_KEYRING_BACKEND = null backend: tests never touch the real keychain
• API-key environment variables are cleared so tests cannot pick up real keys

tests/test_isolation.py fails if the suite ever resolves to the real home, if the application paths are outside the test home, if saving permissions escapes it, or if the real keyring is used.

Verified

• Full suite (503 tests) run normally, with no HOME override: nothing under the real ~/.devorch was created, changed or removed (file list + mtimes identical before/after)
• Without the conftest the isolation tests fail

Action for anyone who ran the tests before

Check ~/.devorch/permissions.yaml. If it contains only edit: allow and filesystem: allow, run devorch permissions reset (this also resets your saved rules, which were already overwritten).