docs: adopt shared mobile navigation and compact terminals - #46
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The browser tests do not fully enforce the claimed single-Home-link and section-only sidebar behavior.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Updates sleepKIT documentation to shared HELIA UI alpha.22, adding scoped mobile navigation and compact tabbed terminals.
Changes:
- Pins alpha.22 and regenerates the lockfile.
- Adds mobile section, theme, keyboard, desktop navigation, and terminal tests.
- Updates the existing mobile navigation test.
| File | Description |
|---|---|
astro-site/package.json |
Pins HELIA UI alpha.22. |
astro-site/package-lock.json |
Records the updated dependency. |
astro-site/tests/site.spec.ts |
Adapts existing mobile navigation coverage. |
astro-site/tests/mobile-sections.spec.ts |
Adds navigation and terminal browser coverage. |
Files not reviewed (1)
- astro-site/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+23
to
+32
| const guideLinks = await sidebar.locator('a').evaluateAll(links => links.map(link => link.getAttribute('href'))); | ||
| await menu.click(); | ||
| await summary.click(); | ||
| await page.getByRole('navigation', { name: 'Choose section' }).getByRole('link', { name: 'Getting started', exact: true }).click(); | ||
| await expect(summary).toContainText('Getting started'); | ||
| await menu.click(); | ||
| await expect(sidebar.locator('[data-helia-sidebar-heading]')).toHaveText('Getting started'); | ||
| const startLinks = await sidebar.locator('a').evaluateAll(links => links.map(link => link.getAttribute('href'))); | ||
| expect(startLinks.length).toBeGreaterThan(0); | ||
| expect(startLinks).not.toEqual(guideLinks); |
| .locator('nav[aria-label="Main"] summary') | ||
| .filter({ hasText: /^Tasks$/ }) | ||
| .click(); | ||
| await page.locator('[data-helia-section-dropdown] summary').click(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation uses shared UI alpha.20, leaving mobile navigation inconsistent with heartKIT. Adopt released alpha.22 so the header offers a section dropdown and the sidebar shows the selected section. Terminal blocks inside tabs use compact frames with copy controls.
Pin the immutable release commit and regenerate the lockfile with npm. Product content, branding, URLs and runtime are unchanged. Browser coverage exercises keyboard dismissal, section switching, sidebar scope, light/dark themes and desktop navigation.
Validation: clean npm installation, documentation build and type checks, relevant output/reference/link checks, and 17 browser cases passed locally. Mobile screenshots inspected.
No runtime or hardware tests were needed for this documentation change. Merge and deployment remain pending approval.
Closes #45.