Skip to content

KVarN exact-tail: fail-closed GGML_ABORT on unsupported structured body instead of materialization fallback #158

Description

@raufaser

ggml/src/ggml-cuda/fattn-tail.cuh:713 aborts the process ("unsupported structured body in exact-tail attention") when the exact-tail path packs a body whose structured form uses views and the KVarN re-dispatch of the packed body fails. Aborting instead of degrading to the materialized route is the issue; filed separately per review request on PR #149.

Reproducer (from the PR #149 review thread):

GGML_KVARN_TEST_NKV_LADDER_ONLY=1 GGML_KVARN_TEST_LADDER_TAIL=128 <test-kvarn>

History observed on gfx1100 (RX 7900 XTX):

Suggestion: where the packed body is unsupported, degrade to materialization rather than GGML_ABORT. Keeping this open for the maintainer to decide whether the remaining risk warrants the fallback or the issue can close with the PR.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions