VULKAN CRASH FIX Gate DFlash graph argmax/top-k to CUDA backend#88
Open
scriptnapps wants to merge 1 commit into
Open
VULKAN CRASH FIX Gate DFlash graph argmax/top-k to CUDA backend#88scriptnapps wants to merge 1 commit into
scriptnapps wants to merge 1 commit into
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX crashing on Vulkan windows build
DFlash builds
ggml_argmax_ext/ggml_topk_extinto the draft graph, but only the CUDA backend implements their extended semantics; on other backends (Vulkan, Metal, CPU, ...) the stock argmax kernel leaves most of the compact ids/probs tensor uninitialized, producing garbage drafts. This PR adds adflash_graph_argmaxcparams flag, set only when the output device backend is CUDA, and falls back to full-logits CPU scanning (and full-logits verification, with a one-time warning) everywhere else. No behavior change on CUDA.Additional information
Observed on AMD RX 9070 XT with the Vulkan backend, where DFlash drafting was broken out of the box. The check is name-based (
strcmp(reg_name, "CUDA")); could be replaced with a proper backend capability query if other backends gain support.Requirements