Skip to content

fix: require non-empty string values for required security secrets - #656

Merged
0xNgoo merged 3 commits into
Anchor-kit:mainfrom
Yungmon22:security/issue-636-require-string-values-for-required-security
Sep 30, 2026
Merged

0xNgoo merged 3 commits into
Anchor-kit:mainfrom
Yungmon22:security/issue-636-require-string-values-for-required-security

Conversation

@Yungmon22

Copy link
Copy Markdown
Contributor

Overview

This PR tightens SecurityConfigSchema validation so required security secrets must be non-empty strings, and adds focused test coverage for the behavior described in the issue. The change is narrowly scoped to the schema's secret validation and its tests.

Related Issue

Changes

🔒 Security Config Validation

  • [MODIFY] tests/utils/server-config-schema.test.ts
    • Added focused SecurityConfigSchema cases for each required secret field: sep10SigningKey, interactiveJwtSecret, and distributionAccountSecret.
    • Covers missing, empty, whitespace-only, and non-string values so invalid secret configuration fails validation.
    • Covers valid string secrets passing validation without being modified.

Verification Results

bun test
Acceptance Criteria Status
Missing, empty, whitespace-only, and non-string secrets fail validation ✅ Covered by new SecurityConfigSchema cases per required secret field
Valid string secrets pass without being modified ✅ Covered by new SecurityConfigSchema cases per required secret field

Closes #636

@drips-wave

drips-wave Bot commented Sep 29, 2026

Copy link
Copy Markdown

@Yungmon22 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@0xNgoo
0xNgoo merged commit cf012e4 into Anchor-kit:main Sep 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require string values for required security secrets

3 participants