Repository navigation
feat(app): the card can leave out the picture and the name - #94
Merged
Merged
Conversation
✅ Deploy Preview for angularians ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #93
Summary
On a GitHub profile the README card sits next to the GitHub avatar and username, so the share dialog can now leave either off.
<app-share> dialog <app-period-tabs> + [Hide picture] [Hide name] (labels say what a press does) <app-country-select> <app-card-badge-options>app/src/app/profile/card-options.ts: reads and writes every card option (badges, picture, username) for the card route, the share dialog and the profile's link preview.avatarandusernamejoinnetlify-vary;CARD_DESIGNis 19, so the dialog does not show a card the browser kept.Evidence
/erkamyaman/card.png?avatar=off&name=offrenders without both (checked locally, with a 4-digit rank too).pnpm test,pnpm typecheckandpnpm buildpass.Merge Danger
Door: two-way
Blast Radius: cards
Cards without the new parameters render as before; the one shared change is the
v=19preview URL.