Skip to content

feat(app): the card can leave out the picture and the name - #94

Merged
erkamyaman merged 2 commits into
mainfrom
feat/card-identity
Nov 15, 2026
Merged

erkamyaman merged 2 commits into
mainfrom
feat/card-identity

Conversation

@erkamyaman

@erkamyaman erkamyaman commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Closes #93

Summary

On a GitHub profile the README card sits next to the GitHub avatar and username, so the share dialog can now leave either off.

 /:username/card.png?period=&flag=&hide=&names=
+  &avatar=off   no picture
+  &username=off no username
 <app-share> dialog
   <app-period-tabs>
+  [Hide picture] [Hide name]   (labels say what a press does)
   <app-country-select>
   <app-card-badge-options>
  • app/src/app/profile/card-options.ts: reads and writes every card option (badges, picture, username) for the card route, the share dialog and the profile's link preview.
  • With either hidden, the left column centres on the stat tiles; with both hidden the rank grows (84 → 128) and the points (30 → 36).
  • avatar and username join netlify-vary; CARD_DESIGN is 19, so the dialog does not show a card the browser kept.

Evidence

  • Before: the card always drew the avatar and the username.
  • After: /erkamyaman/card.png?avatar=off&name=off renders without both (checked locally, with a 4-digit rank too). pnpm test, pnpm typecheck and pnpm build pass.

Merge Danger

Door: two-way

Blast Radius: cards

Cards without the new parameters render as before; the one shared change is the v=19 preview URL.

@netlify

netlify Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for angularians ready!

Name Link
🔨 Latest commit 60775d4
🔍 Latest deploy log https://app.netlify.com/projects/angularians/deploys/6afa0df31efb5643df1e514b
😎 Deploy Preview https://deploy-preview-94--angularians.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@erkamyaman
erkamyaman merged commit 4d07a82 into main Nov 15, 2026
4 of 5 checks passed
@erkamyaman
erkamyaman deleted the feat/card-identity branch November 15, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

duplicate profile photo

1 participant