ci(fix): resolve lint failure, broken coverage task, and redundant test runs#39
Merged
Conversation
The --stacks option on the plan command was using `{ complete: completeStackNames } as any`
to bypass Cliffy's type system. This triggered the `no-explicit-any` lint rule, causing
CI to fail at the lint step.
Replaced with the documented `.complete("stacks", completeStackNames)` chain method
which is fully typed and the idiomatic Cliffy approach.
Added a dedicated `test:coverage` task that runs tests with --coverage=.coverage for CI use, keeping the `test` task lightweight for local dev (coverage instrumentation adds 5-20% overhead). Fixed the `coverage` task which was missing the .coverage directory argument. Previously `deno task coverage` errored with "No coverage files found" because it defaulted to the current directory instead of the coverage output directory.
Previously tests ran twice in CI: once via `deno task test` (no coverage) and again via `deno test ... --coverage=.coverage` in the coverage step. This doubled CI test time. Consolidated to a single test pass with coverage using `deno task test:coverage`, followed by `deno task coverage` to generate the detailed report. Also added .slim/deepwork/ to .gitignore and created .ignore to allow deepwork files for agent-assisted development sessions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves three issues causing CI to fail on the default branch:
1. Lint failure:
no-explicit-anysrc/cli/mod.ts:1492used{ complete: completeStackNames } as anyto bypass Cliffy's type system. Replaced with the documented.complete("stacks", completeStackNames)chain API which is fully typed.2. Broken coverage task
deno task coverageerrored with "No coverage files found" because the path.coveragewas missing. Fixed the task and added atest:coveragetask for CI use (keepingtestlightweight for local dev).3. Redundant test runs in CI
Tests ran twice: once via
deno task testand again in the coverage step viadeno test --coverage=.coverage. Consolidated to a singletest:coveragepass.Validation (all passing locally)
fmt:check-- 54 files, 0 issueslint-- 54 files, 0 issues (was failing before)check(type) -- passtest-- 357 passed, 0 failedtest:coverage-- 357 passed, 0 failedcoverage-- detailed report generated