fix: show Upsun disk sizes on macOS without numfmt - #178
Open
stantheman0128 wants to merge 2 commits into
Open
stantheman0128 wants to merge 2 commits into
stantheman0128 wants to merge 2 commits into
Conversation
macOS does not ship numfmt, so ddev ucc stopped before it could show assigned and available storage. Co-authored-by: Cursor <cursoragent@cursor.com>
The Darwin check was matching its own explanation. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #155.
upsun_disk_helperformatted byte counts with GNUnumfmt. This Mac has nonumfmt(command not found).format_iecprints the same 1024-based sizes with python3:1048576is1.00M, and a storage value already in mebibytes is scaled by 1048576 first, matching--from-unit=1048576.prepared with Cursor
Verification
Red, this Mac:
Green:
ddevwas not run. The test only checks the two conversions the helper used to hand to numfmt.Made with Cursor