chore: delete models-design folder (#260) - #266
Merged
Conversation
Removes the models-design/ directory (drawio diagrams) at the repo root, which is no longer referenced anywhere in the codebase or docs.
tbittar
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process ID
Process: GP-02
Description
Deletes the
models-design/folder at the repo root, per #260. The folder contained only draw.io diagram files (model library, port library, and system diagrams) and was not referenced anywhere else in the codebase or documentation.Note: the issue title says
models_design(underscore), but the actual directory in the repo is namedmodels-design(hyphen) — that's the one removed.Impact Analysis
No source modules (
expression/,simulation/,study/,optim_config/) are affected — this only removes non-code design assets. Solver output values are not expected to change.Checklist
pytest) — 587 passed, 6 skipped, 2 xfailed (pre-existing, unrelated)mypy) — no issues found in 66 source filesblack,isort) — cleanpyproject.tomlversion bumped if applicable (not applicable — no code/package impact)AGENTS.mdreviewed for impact and updated if needed (no references found)