Repository navigation
temiport25: NavBar i18n + memoization - #855
Merged
usmanimamu17-create merged 2 commits intoOct 16, 2026
Merged
usmanimamu17-create merged 2 commits into
usmanimamu17-create merged 2 commits into
Conversation
|
@temiport25 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internationalizes the remaining hard-coded NavBar copy (#805) and memoizes the component's computations (#807).
t('common.mainnet'),t('common.retryQueue')andt('common.admin')so all three locales cover them.React.memo;isAdminis auseMemoderivation,handleLogoutis auseCallback, and the public/admin link lists areuseMemo-built so a parent layout re-render no longer re-computes them (proven in the test via theuseSessioncall count).Adds
tests/navbar-i18n-memo.test.tsx(6 tests) with atspy asserting the requested keys. Note: the i18n message bundles are corrupted in this checkout (binary), so the provider is mocked; repo-widetsc/vitestfailures are pre-existing and unrelated.Closes #804
Closes #805
Closes #806
Closes #807