Repository navigation
projectsfame: reusable NavLinks + nav empty state - #856
Merged
usmanimamu17-create merged 2 commits intoOct 16, 2026
Merged
usmanimamu17-create merged 2 commits into
usmanimamu17-create merged 2 commits into
Conversation
|
@projectsfame Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the NavBar link list into a reusable component (#803) and gives it a designed empty state (#801).
src/components/shell/nav-links.tsxowns the destinations as plain data (NAV_LINKS) plus aNavLinkscomponent, so any nav surface (desktop bar today, a mobile drawer/command palette later) can reuse it.Navigationnow just composes it, andADMIN_ROUTESis derived from the same data so it can't drift from what the bar renders.NavLinksrenders a labelled empty state (role="status") instead of leaving the bar blank.Adds
tests/nav-links.test.tsx(9 tests). Note: the i18n message bundles are corrupted in this checkout (binary), so the provider is mocked; repo-widetsc/vitestfailures are pre-existing and unrelated.Closes #800
Closes #801
Closes #802
Closes #803