Skip to content

projectsfame: reusable NavLinks + nav empty state - #856

Merged
usmanimamu17-create merged 2 commits into
ApexChainx:mainfrom
projectsfame:projectsfame/navbar-reusable-empty-state
Oct 16, 2026
Merged

usmanimamu17-create merged 2 commits into
ApexChainx:mainfrom
projectsfame:projectsfame/navbar-reusable-empty-state

Conversation

@projectsfame

Copy link
Copy Markdown
Contributor

Extracts the NavBar link list into a reusable component (#803) and gives it a designed empty state (#801).

  • Extract NavBar into a reusable component #803 extract into a reusable component — new src/components/shell/nav-links.tsx owns the destinations as plain data (NAV_LINKS) plus a NavLinks component, so any nav surface (desktop bar today, a mobile drawer/command palette later) can reuse it. Navigation now just composes it, and ADMIN_ROUTES is derived from the same data so it can't drift from what the bar renders.
  • Improve empty-state design for NavBar #801 empty-state design — when the filtered link set is empty (e.g. a non-admin who only has admin-only destinations) NavLinks renders a labelled empty state (role="status") instead of leaving the bar blank.

Adds tests/nav-links.test.tsx (9 tests). Note: the i18n message bundles are corrupted in this checkout (binary), so the provider is mocked; repo-wide tsc/vitest failures are pre-existing and unrelated.

Closes #800
Closes #801
Closes #802
Closes #803

@drips-wave

drips-wave Bot commented Oct 16, 2026

Copy link
Copy Markdown

@projectsfame Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@usmanimamu17-create
usmanimamu17-create merged commit f142184 into ApexChainx:main Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract NavBar into a reusable component Add dark mode support to NavBar Improve empty-state design for NavBar Add analytics events to NavBar

2 participants