Skip to content

northersubair: reusable landing view + empty state - #858

Merged
usmanimamu17-create merged 2 commits into
ApexChainx:mainfrom
northersubair:northersubair/landing-reusable-empty-state
Oct 16, 2026
Merged

usmanimamu17-create merged 2 commits into
ApexChainx:mainfrom
northersubair:northersubair/landing-reusable-empty-state

Conversation

@northersubair

Copy link
Copy Markdown
Contributor

Extracts the landing view into a reusable component (#787) and adds a designed empty state (#785).

  • Extract LandingPage into a reusable component #787 extract into a reusable component — new src/components/landing/landing-view.tsx owns the "render a lazily-loaded dashboard, or an empty state" branch. Navigation-style routes can now reuse it for any dashboard instead of duplicating the logic; src/app/page.tsx composes <LandingView view={SLADashboardView} />.
  • Improve empty-state design for LandingPage #785 empty-state design — LandingView renders a designed, announced empty state (role="status") when isEmpty, and accepts a caller-supplied emptyState node. LandingEmptyState is exported for direct reuse.

Adds tests/landing-view.test.tsx (6 tests).

Scope note: the landing dashboard view (src/components/dashboard/sla-dashboard-view.tsx) is corrupted upstream (a 0-byte file) and is deliberately left untouched, per the issue-only approach. Tests mock next/dynamic so the corrupted module is never executed; the TS2306 ... is not a module error is pre-existing.

Closes #784
Closes #785
Closes #786
Closes #787

@drips-wave

drips-wave Bot commented Oct 16, 2026

Copy link
Copy Markdown

@northersubair Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@usmanimamu17-create
usmanimamu17-create merged commit a1f0261 into ApexChainx:main Oct 16, 2026
0 of 3 checks passed
@grantfox-oss grantfox-oss Bot mentioned this pull request Oct 16, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants