Repository navigation
northersubair: reusable landing view + empty state - #858
Merged
usmanimamu17-create merged 2 commits intoOct 16, 2026
Merged
usmanimamu17-create merged 2 commits into
usmanimamu17-create merged 2 commits into
Conversation
|
@northersubair Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the landing view into a reusable component (#787) and adds a designed empty state (#785).
src/components/landing/landing-view.tsxowns the "render a lazily-loaded dashboard, or an empty state" branch.Navigation-style routes can now reuse it for any dashboard instead of duplicating the logic;src/app/page.tsxcomposes<LandingView view={SLADashboardView} />.LandingViewrenders a designed, announced empty state (role="status") whenisEmpty, and accepts a caller-suppliedemptyStatenode.LandingEmptyStateis exported for direct reuse.Adds
tests/landing-view.test.tsx(6 tests).Scope note: the landing dashboard view (
src/components/dashboard/sla-dashboard-view.tsx) is corrupted upstream (a 0-byte file) and is deliberately left untouched, per the issue-only approach. Tests mocknext/dynamicso the corrupted module is never executed; theTS2306 ... is not a moduleerror is pre-existing.Closes #784
Closes #785
Closes #786
Closes #787