Repository navigation
amberly-d: landing page i18n + memoization - #859
Merged
usmanimamu17-create merged 2 commits intoOct 16, 2026
Merged
usmanimamu17-create merged 2 commits into
usmanimamu17-create merged 2 commits into
Conversation
|
@amberly-d Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internationalizes the landing page loading state (#789) and memoizes the route (#791).
t("dashboard.loading")viauseI18n(), so the landing route follows the app locale. The fallback announces itself withrole="status"/aria-live="polite".LandingLoading) and the route component are both wrapped inReact.memoand defined at module scope, so their element types stay stable and the subtree is reused instead of re-created while the dashboard chunk loads.Adds
tests/landing-page-i18n-memo.test.tsx(4 tests).Scope note: the landing dashboard view (
src/components/dashboard/sla-dashboard-view.tsx) and the i18n message bundles are corrupted upstream (a 0-byte file and binary JSON respectively) and are deliberately left untouched, per the issue-only approach. Tests mock@/i18n/i18nandnext/dynamic, so neither corrupted module is executed; theTS2306 ... is not a moduleerror is pre-existing.Closes #788
Closes #789
Closes #790
Closes #791