Skip to content

amberly-d: landing page i18n + memoization - #859

Merged
usmanimamu17-create merged 2 commits into
ApexChainx:mainfrom
amberly-d:amberly-d/landing-i18n-and-memoization
Oct 16, 2026
Merged

usmanimamu17-create merged 2 commits into
ApexChainx:mainfrom
amberly-d:amberly-d/landing-i18n-and-memoization

Conversation

@amberly-d

Copy link
Copy Markdown
Contributor

Internationalizes the landing page loading state (#789) and memoizes the route (#791).

  • Add i18n translations for LandingPage #789 i18n translations — the hard-coded "Loading dashboard..." string is replaced by t("dashboard.loading") via useI18n(), so the landing route follows the app locale. The fallback announces itself with role="status" / aria-live="polite".
  • Memoize expensive computations in LandingPage #791 memoize expensive computations — the translated fallback (LandingLoading) and the route component are both wrapped in React.memo and defined at module scope, so their element types stay stable and the subtree is reused instead of re-created while the dashboard chunk loads.

Adds tests/landing-page-i18n-memo.test.tsx (4 tests).

Scope note: the landing dashboard view (src/components/dashboard/sla-dashboard-view.tsx) and the i18n message bundles are corrupted upstream (a 0-byte file and binary JSON respectively) and are deliberately left untouched, per the issue-only approach. Tests mock @/i18n/i18n and next/dynamic, so neither corrupted module is executed; the TS2306 ... is not a module error is pre-existing.

Closes #788
Closes #789
Closes #790
Closes #791

@drips-wave

drips-wave Bot commented Oct 16, 2026

Copy link
Copy Markdown

@amberly-d Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@usmanimamu17-create
usmanimamu17-create merged commit 3779690 into ApexChainx:main Oct 16, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants