Repository navigation
Highlight all join arrival edges and show Fork/Join badges in WorkflowViewer (#227) - #228
Merged
Merged
Conversation
Contributor
Author
|
Verified the AND-join assumption against the runtime: Axiom executes via Caveat: Axiom does not currently pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #227.
traversedEdgeIds(utils/parallelView.ts) adds every incoming edge of a join that has fired, plus edges of branches waiting ininstance.joinArrivals.analyzeParallelRegionsand passesparallelRoleto nodes, so Fork/Join badges render as in the Editor.Assumes the Axiom runtime uses the same AND-join semantics as
analyzeParallelRegions.