docs: fix dead inlang translation links (moved to Fink) - #8972
Open
1t1sCooL wants to merge 2 commits into
Open
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the README translation links from the retired inlang editor and badge endpoint to Fink, replacing the broken badge image with a working plain text link. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="README.md" line_range="99" />
<code_context>
To add translations, you can manually edit the JSON translation files in `/frontend/resources/translations`, use
-the [inlang online editor](https://inlang.com/editor/github.com/AppFlowy-IO/AppFlowy), or
+the [inlang online editor](https://fink.inlang.com/github.com/AppFlowy-IO/AppFlowy), or
run `npx inlang machine translate` to add missing translations.
</code_context>
<issue_to_address>
**nitpick:** The README still labels the destination as the “inlang online editor,” but the link now opens Fink, so the documentation identifies the service incorrectly and can confuse contributors looking for the editor.
**Suggested fix:** Rename the link text to “Fink online editor” or “Fink editor.”
```suggestion
the [Fink online editor](https://fink.inlang.com/github.com/AppFlowy-IO/AppFlowy), or
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inlang translation links in the README are dead — inlang moved its online editor to the Fink app and retired the old badge endpoint:
https://inlang.com/editor/github.com/AppFlowy-IO/AppFlowy(and its?ref=badgevariant) → 404 →https://fink.inlang.com/github.com/AppFlowy-IO/AppFlowy(HTTP 200, loads the AppFlowy project).https://inlang.com/badge?url=...→ 404 with no working successor endpoint (badge.inlang.com 403s even via camo), so the broken badge image was replaced with a plain "Translate on Fink" link.Summary by Sourcery
Update README translation links to use Fink’s working AppFlowy editor.
Bug Fixes:
Documentation: