Repository navigation
Release 0.3.11: recognise TV-Store's own catalog entry under a renamed package id - #40
Merged
Merged
Conversation
Apps2Samsung can install TV-Store under a new package id (its "Install under a new package id" option rewrites the package part of every id). self() matched the catalog entry by package id only, so such a copy never saw its own entry and the self-update notice never showed. self() now also matches by the application part of the id, which the rename keeps, plus the entry name. A renamed copy cannot update itself: an install from here would land a second TV-Store under the catalog id. So instead of the Update button it tells the user to update from Apps2Samsung, which remembers the renamed id and updates the right tile.
PatrickSt1991
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to Apps2Samsung's "Arm TV-Store: find a TV-Store installed under a new package id" PR.
Apps2Samsung can install TV-Store under a new package id (#839 there; a tester's set lists it as
KUW3HHjMUR.Store). The rename rewrites the package part of every id and leaves the application part and the name alone.self()matched TV-Store's own catalog entry by package id only, so a renamed copy never found itself: no self-update notice, ever. It now also matches on the application part of the id (Store) plus the entry name.A renamed copy must not update itself from here: the install would go out under the catalog's
A2STVStoreand land a second TV-Store next to the renamed one. So when the catalog has a newer version and this copy runs under another package id, the home screen shows the version notice without the Update button and sends the user to Apps2Samsung (On the TV, Update), which remembers the renamed id and updates the right tile.Verified:
node --checkon app.js and the repo's test runner pass. Not run on the tester's TV.Version
Bumped to 0.3.11 (config.xml, app.js VERSION, README status table), so the release workflow's tag check passes on
v0.3.11.