Repository navigation
Let the adaptor take a prepared handler, not only a class - #10
Merged
Merged
Conversation
Naming the handler class means execute says handlerClass new and uses the object in the same line - nobody ever holds it, so a handler that has to be told something cannot be told anything. A metrics endpoint that has to know which domains it exports, and under which prefix, has nowhere to be told. A handler given as an object is now used as it is; given as a class, a fresh one per request as before. All four existing routes name a class and are untouched. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Naming the handler class means execute says handlerClass new and uses the object in the same line - nobody ever holds it, so a handler that has to be told something cannot be told anything. A metrics endpoint that has to know which domains it exports, and under which prefix, has nowhere to be told.
A handler given as an object is now used as it is; given as a class, a fresh one per request as before. All four existing routes name a class and are untouched.