Repository navigation
Let a call carry a prepared Zinc handler - #14
Merged
Merged
Conversation
HOPZincHandlerAdaptor mounts a foreign Zinc handler by naming its class and saying handlerClass new on every request. That leaves nobody a moment to configure the handler - the object is born inside execute and used in the same line. A metrics endpoint that has to be told which domains it exports, and under which prefix, has nowhere to be told. Calls already answer themselves as route handlers, which is how AGPluggableCall is hung into a route with its block already set. HOPZincHandlerCall does the same for anything that answers handleRequest:, so the route can prepare it where it is built - which is where the deployment knows what it wants. HOP-Extra had no test package; it has one now. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOPZincHandlerAdaptor mounts a foreign Zinc handler by naming its class and saying handlerClass new on every request. That leaves nobody a moment to configure the handler - the object is born inside execute and used in the same line. A metrics endpoint that has to be told which domains it exports, and under which prefix, has nowhere to be told.
Calls already answer themselves as route handlers, which is how AGPluggableCall is hung into a route with its block already set. HOPZincHandlerCall does the same for anything that answers handleRequest:, so the route can prepare it where it is built - which is where the deployment knows what it wants.
HOP-Extra had no test package; it has one now.