Repository navigation
A previous version whose counts cannot fit ends the chain before anyt… - #1337
Merged
Merged
Conversation
…efore reading it The check of 62398e23 followed the previous version of 1:30197 into the bytes of another record. Read as a head they gave 530 million behavior descriptions, #readHeadFrom: asked for a collection of four gigabytes, and the scheduler was killed; the overlap guard of #versionsOf:in:onFault:do: only looks after the head has been read. Before the walk reads a previous version, SoilConsistencyTracker reads the three counts from the raw bytes (#countsOfHeadAt:in:fitBefore:) and holds each against the bytes left before the record after it, or before the end of the file. A count that cannot fit is a read error, and the chain ends there as a SoilBrokenVersionChain at the last record that is fine. Nothing outside the tracker changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
noha
force-pushed
the
a-head-that-cannot-fit-ends-the-chain
branch
from
October 10, 2026 07:55
a79d4d4 to
03e5fd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hing is allocated
The check of 62398e23 followed the previous version of 1:30197 into the bytes of another record. Read as a head they gave 530 million behavior descriptions, #readHeadFrom: asked for a collection of four gigabytes, and the scheduler was killed; the overlap guard of #versionsOf:in:onFault:do: only looks after the head has been read.
The chain walk now reads a previous version with #headAtPosition:before:, which holds every count of the head against the bytes left before the record after it, or before the end of the file, before it allocates (SoilPersistentClusterVersion>>readHeadFrom:within:). A count that cannot fit is a read error, and the chain ends there as a SoilBrokenVersionChain at the last record that is fine. #readHeadFrom:, which every read takes, is left as it is.