Repository navigation
The tracking visitor lets go of the indexes it opened - #1338
Merged
Merged
Conversation
The index manager keeps every index it is asked for open, file and all. SoilTrackingVisitor>>processIndexId:segment: asked it for each index of the database and never gave one back, so a check held every index file open at once. 62398e23 has 3319 indexes against the 1024 files the scheduler may hold open, and the check ended on the next index it opened with nothing but the path of that file as its error. An index the walk opened is now removed from its manager (and closed) once it has been read, as SoilBackupVisitor>>copyIndexAt:segment: already does. One that was open before the walk stays open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The index manager keeps every index it is asked for open, file and all. SoilTrackingVisitor>>processIndexId:segment: asked it for each index of the database and never gave one back, so a check held every index file open at once. 62398e23 has 3319 indexes against the 1024 files the scheduler may hold open, and the check ended on the next index it opened with nothing but the path of that file as its error.
An index the walk opened is now removed from its manager (and closed) once it has been read, as SoilBackupVisitor>>copyIndexAt:segment: already does. One that was open before the walk stays open.