Repository navigation
Add runs:read to the Lambda scopes in the integration test - #328
Merged
Merged
Conversation
The lambda preset in web/lib/api/scope-catalog.ts gained runs:read in #242, but the integration test's copy of that list was not updated. This adds the scope so the test mints a token with the same scopes as the preset. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runs:readto_LAMBDA_PRESET_SCOPESinlambda/tests/integration/test_lambda_api.py, so the list matches thelambdapreset inweb/lib/api/scope-catalog.ts.runs:readin Keep same-named files from different folders in one run #242, but the test's copy of the list was not updated.Why it matters
The integration test mints its token from this list. It was checking a token with one scope fewer than the preset gives.
Testing
make py-checkpasses.make py-test-unit: 1093 passed.uv run pytest -m integration -k TestLeastPrivilegeLambdaScopes: 1 passed.This is a test-only change, so it does not need a changelog entry.
Made with Cursor