Skip to content

shots skill: pass --project to shots upload for the Company Room post - #66

Merged
ark-archastro merged 2 commits into
mainfrom
ark/shots-upload-project
Oct 14, 2026
Merged

ark-archastro merged 2 commits into
mainfrom
ark/shots-upload-project

Conversation

@ark-archastro

@ark-archastro ark-archastro commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review on ArchCode

Problem and author intent

archdev CLI v0.53.0 (released 2026-10-13, firstlanding #18144) makes archdev shots upload post the run's stills to the organization's Company Room after the Media upload, filed under --project <prj_id> like every other stream post. Section 6 of the shots skill still shows the bare shots upload command and does not mention the post, so an agent that follows it:

  1. runs archdev shots upload --feature <f> --root <root> with no --project;
  2. the CLI uploads, posts the stills untagged, and prints the untagged-post warning;
  3. the post lands in the stream with no project, and the agent has no instruction for fixing it or for what stream <status> means.

Teammates get screenshots in the stream, but outside any project, and agents may also attach the same PNGs to a done post with -a, duplicating them.

What changed

shots/SKILL.md section 6, mirrored into every plugins/*/skills/shots/SKILL.md by npm run build:

  • The example command now carries --project <prj_id>, and the text says the upload posts the stills to the Company Room and how to find the project ID (same ID as archdev log post).
  • New subsection "The Company Room post" explains the post (Shots page link, up to ten stills by Media id, no movie rows), the stream_post.status values posted, unchanged, retagged and no_room, how to retag an untagged post by rerunning with --project, and that a failed post is retried onto one message by rerunning.
  • Tells agents not to also attach the PNGs to a done or start post.
  • Output description updated: text mode prints stream <status> [<message-id>], --json adds stream_post.
  • The frontmatter description notes the upload also posts to the Company Room.

The header's minimum moves from 0.52.1 to 0.53.0, since the example now uses a flag 0.52.x rejects; it tells agents to check archdev --version and ask the person to run archdev upgrade. The catalog version (0.49.7) is not bumped; this is a skill text change, not a CLI release.

Scope: docs only (skill text and generated plugin mirrors).

Risk: low. Prose that agents read; no code or hook wiring changes. The regenerated mirrors are byte-identical copies made by the checked generator.

User impact: agents following the skill now file their screenshot posts under the right project and can fix an untagged post.

Testing

  • tools/plugin-gen: npm run build, npm run check (132 generated files match), npm run typecheck, npm test (62 pass). The Harness plugins workflow runs the same on this PR.
  • The behavior the text describes is what the CLI does: verified against the v0.53.0 binary (archdev shots upload --help lists --project <id>) and by the firstlanding CLI e2e tests/integration/shots_upload_e2e.rs (posted, unchanged, retagged, no_room, failed-post retry), which shipped with #18144.
  • No end-to-end test exercises skill prose; the proof that agents follow it is observational.

🤖 Generated with Claude Code

…mpany Room post

archdev 0.53.0 makes `archdev shots upload` post the run's stills to the
organization's Company Room after the Media upload. Section 6 of the skill
still showed the bare command, so agents following it posted untagged and
got the CLI's warning. The section now puts `--project <prj_id>` in the
example, explains the post and its `stream_post.status` values (posted,
unchanged, retagged, no_room), says how to retag an untagged post by
rerunning with `--project`, and tells agents not to also attach the PNGs
to a `done` post. Plugin mirrors regenerated with `npm run build`.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T00:24:32.172575Z 2ea8cd6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ea8cd6f0a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread shots/SKILL.md
The upload example now uses `--project`, which 0.52.x rejects as an
unknown argument, so the header's minimum moves to 0.53.0 (released
2026-10-13) and tells agents to check `archdev --version` and ask the
person to run `archdev upgrade`. The subsection no longer carries its own
version note. Plugin mirrors regenerated.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@ark-archastro
ark-archastro merged commit dbc58f5 into main Oct 14, 2026
20 checks passed
@ark-archastro
ark-archastro deleted the ark/shots-upload-project branch October 14, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant