Repository navigation
feat: quarantine known flakes, webhook notifications and test-tracking docs (P4) - #148
Merged
Merged
Conversation
Contributor
Author
|
ArchDev is watching this pull request. State: watching (cycle 3 of 3 for head fb75912).
Paused by the |
calvin-archastro
marked this pull request as draft
October 15, 2026 19:38
calvin-archastro
force-pushed
the
feat/quarantine
branch
from
October 15, 2026 19:49
06b81ec to
8bbbcac
Compare
calvin-archastro
marked this pull request as ready for review
October 15, 2026 19:56
calvin-archastro
marked this pull request as draft
October 15, 2026 20:35
calvin-archastro
marked this pull request as ready for review
October 15, 2026 20:43
calvin-archastro
marked this pull request as draft
October 16, 2026 17:20
…e changes The classifier now keeps a quarantine list at the end of each pass: a test that is not broken enters after definite flakes from 2 different runs in 7 days, and leaves after 20 consecutive passes, when it breaks, or after 30 days. A released or expired test is judged only on events after it left. Every change is logged, and the newest log id is the list's version. GET /v1/test-results/quarantine serves the list to CI with the upload's OIDC token, tests?state=quarantined filters by it, and /ui/quarantine shows it with its recent changes. ASTER_SRV_WEBHOOKS names endpoints and the events each wants (test.quarantined, test.released, test.expired, test.broken). The pass records deliveries in its own transaction; a sender posts them signed with X-Aster-Signature (HMAC-SHA256) and retries with backoff, so a failing endpoint never holds up ingest or classification. Retention drops the quarantine log and deliveries after the retention period. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
With test capture on, Aster loads the quarantine at start: aster-srv's list (cached in .aster/quarantine.json, which stands in for up to 24 hours when the server is unreachable) and aster-quarantine.toml, whose entries need a reason and an expiry date. The line it prints names both and the server list's version. ASTER_QUARANTINE=off turns it off. A failed target passes only when, after retries, every failing test is quarantined, its results are complete, and it exited with its runner's "tests failed" code (ExUnit 2, nextest 100, pytest/go/jest/vitest/node 1; never for Gradle, Maven or cargo test, whose code also means a compile error). Its dependents then run, the pass is not cached, each let-through test gets a GitHub warning, the result says (quarantined: N), and the results file marks those attempts quarantined so the step summary lists them apart from the failures. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Cached targets record no tests, so a quarantined test's streak needs only test_results and runs, not target_runs. On the 11.7M-result perf copy, 2,000 quarantined tests with six days of history take about 1.8s in one query (about 1ms each); a realistic list is a few dozen. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…book docs/test-tracking.md walks the loop from capture per runner through upload, labels, flake classification and quarantine, with the environment variables and a GitHub Actions job. The README gets a quarantine section and GETTING_STARTED points at the guide. The aster-srv README documents the quarantine rules and feed, webhooks (payloads, signature, retries), the new settings and a runbook. Tests parse the documented aster-quarantine.toml and ASTER_SRV_WEBHOOKS examples against a fixture test, so they stay accurate. The spec's P4 tasks now say what was built. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A replica whose clock is behind the committed watermark would re-derive test state, quarantine and webhook notifications as of an earlier time, undoing a break and announcing it again on the next pass. Re-read the watermark under the lock and skip the window when it is already covered. Quarantine day arithmetic now uses 24-hour intervals so entry windows and expiry do not shift by an hour across a DST change in the session zone.
Cached targets store the results they replay, so a release streak built from test_results alone counted replayed passes. Use the classifier's final-attempt rule, which skips cached targets, and add a regression test. Co-Authored-By: Claude Opus <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
calvin-archastro
force-pushed
the
feat/quarantine
branch
from
October 16, 2026 17:29
fb75912 to
4d7ca05
Compare
calvin-archastro
marked this pull request as ready for review
October 16, 2026 17:36
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge order: #152 is merged; nothing else first. After merging: deploy aster-srv first, then release aster and bump
ASTER_VERSION(see Rollout).P4 of test tracking: T22 quarantine store and feed, T23 enforcement, T26 webhooks, T25 docs.
Rebased onto #149: quarantine matching uses #149's shard-aware test identity (
stream::test_idtakes the report's project), so a quarantined test matches on any shard; the guide documents balanced partitions.What changes
ASTER_SRV_QUARANTINE_RUNS(0 = off),_RELEASE_PASSES,_DAYS.GET /v1/test-results/quarantine,tests?state=quarantined, and a real/ui/quarantinepage.aster-quarantine.tomlat start and prints the list's version and count..aster/quarantine.json; the cache is used for up to 24h when the server is down.cargo test);ASTER_QUARANTINEis notoff.::warningand a step-summary row;"quarantined": true.ASTER_SRV_WEBHOOKSlists endpoints and the events each receives (test.quarantined|released|expired|broken).X-Aster-Signature: sha256=…and retried from 30s, doubling to 6h, then abandoned after 12 attempts.docs/test-tracking.md.Open choice
The auto-quarantine threshold is still open in the spec. I built the proposal (2 runs) and made it configurable:
ASTER_SRV_QUARANTINE_RUNS=1quarantines after one proven flake, without a release.Rollout
/ui/quarantinefor a day.ASTER_SRV_QUARANTINE_RUNS=0.ASTER_VERSION. CI then honours the list.ASTER_QUARANTINE=offis the kill switch for a job.ASTER_SRV_WEBHOOKSas a Pulumi secret.Verification
cargo fmt, clippy-D warningsandcargo doc -D warningsare clean.tests/quarantine.rs:go test:dev_servicesflake.🤖 Generated with Claude Code