Format version - #2012
Open
amilcarlucas wants to merge 2 commits into
Open
Conversation
…rsions ago already This prevents the migration code to run unnecessarly.
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Updates the vehicle components JSON schema to Format version 2 across templates, docs, and migration code.
Changes:
- Bump
"Format version"from1to2in settings template and allvehicle_components.jsontemplates - Update backend constant
VEHICLE_COMPONENTS_FORMAT_VERSIONto2 - Broaden the PowerShell formatting script to rewrite any numeric format version
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| windows/settings_template.json | Updates settings template format version to 2 |
| scripts/force_format_version.ps1 | Changes format-version rewrite rule to match any numeric version |
| ardupilot_methodic_configurator/vehicle_templates/Rover/Carisma_SCA-1E/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/Rover/AION_R1/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/Heli/OMP_M4/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduPlane/normal_plane/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduPlane/empty_4.7.x/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/empty_4.7.x/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/empty_4.6.x/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/empty_4.5.x/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/diatone_taycan_mxc/4.6.x-params/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/diatone_taycan_mxc/4.5.x-params/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/diatone_taycan_mxc/4.4.4-params/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/diatone_taycan_mxc/4.3.8-params/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/X11_plus/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Tarot_X4/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/TarotFY680Hexacopter/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/ReadyToSkyZD550/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Marmotte5v2/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Hoverit_X13/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Hoverit_X11+/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X650_LTE/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500_V2/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/GazeboIrisWithTargetFollow/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/FETtec-5/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/ESM450X-Des/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Demo32Motor_PeterHall/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Chimera7/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Big_Owl/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/vehicle_templates/ArduCopter/AirCar_v1/vehicle_components.json | Bumps template format version to 2 |
| ardupilot_methodic_configurator/data_model_vehicle_project.py | Moves pylint suppression to function signature line |
| ardupilot_methodic_configurator/backend_filesystem_migration.py | Updates canonical vehicle components format version constant to 2 |
| CUSTOMIZING_CONFIGURATION_STEPS.md | Updates documented format version example to 2 |
Suppressed comments (2)
scripts/force_format_version.ps1:1
- This PR’s title/description indicates a bump to format version 2, but the script still forces
\"Format version\"to0(now for any numeric version). If the intent is to keep templates at v2, update the replacement value to 2 (or parameterize the target version so the script can be used for either upgrading or resetting).
scripts/force_format_version.ps1:1 - The regex requires exactly one space after the colon (
\"Format version\": ␠\\d+), so it won’t match valid JSON that uses different whitespace (e.g.,\"Format version\":2or extra spaces). Consider using a whitespace-tolerant pattern like\"Format version\"\\s*:\\s*\\d+to reliably update all templates.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
Author
|
We are not at version 2 yet. Do not merge this!!! |
Contributor
Test Results 4 files + 2 4 suites +2 46m 48s ⏱️ + 32m 8s For more details on these failures, see this check. Results for commit 2002a67. ± Comparison against base commit 0fb3e29. |
Contributor
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update Format version
Checklist
git commit --signoff)Testing
Describe how you tested these changes: