Upgrade pyinstaller - #2016
Upgrade pyinstaller#2016amilcarlucas wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Upgrades the pinned PyInstaller toolchain versions and removes a Tcl/Tk bundling workaround + corresponding CI assertion used when building the Windows/macOS distributables.
Changes:
- Bump
pyinstallerto6.22.2andpyinstaller-hooks-contribto2026.7for win/mac/linux build dependency groups. - Remove custom Tcl/Tk discovery +
TCL_LIBRARY/TK_LIBRARYenvironment setup from the Windows.specfile. - Remove the CI step that asserted Tcl/Tk data files were present in the built Windows artifact.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
windows/ardupilot_methodic_configurator.spec |
Removes explicit Tcl/Tk environment setup previously used to ensure Tk data bundling. |
pyproject.toml |
Updates pinned PyInstaller and hooks-contrib versions for distribution dependency groups. |
.github/workflows/build_windows_macos.yml |
Removes a build-time assertion verifying bundled Tcl/Tk library data presence. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| from PyInstaller.utils.hooks import collect_submodules | ||
| import certifi | ||
| import os |
| throw "PyInstaller did not bundle the Tcl/Tk library data." | ||
| } | ||
| del ardupilot_methodic_configurator.spec | ||
|
|
Test Results 2 files 2 suites 13m 51s ⏱️ Results for commit c76f721. |
c76f721 to
a525b85
Compare
Description
Upgrade pyinstaller and remove an outdated test
Checklist
git commit --signoff)Testing
Describe how you tested these changes: