chore(x500): Update the x500 template - #2067
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
🟡 Changes recommended
Moderate tuning-report consistency findings remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the Holybro X500 ArduCopter 4.6.3 vehicle template with refreshed metadata, configuration, calibration, filtering, and tuning results.
Changes:
- Updates firmware, RC, sensor, safety, and board configuration.
- Refreshes logging, ESC, OSD, GNSS, and controller parameters.
- Adds updated calibration, autotune, quick-tune, and tuning-report data.
Unresolved moderate findings remain in the tuning report: angle gains appear before they are applied, and ATC_RAT_YAW_FLTE=2.090602 is missing from the step-30 column.
File summaries
| File | Summary |
|---|---|
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/vehicle_components.json |
Updates firmware and RC metadata. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/tuning_report.csv |
Updates tuning-step columns and values. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/53_system_id_mixer_roll.param |
Disables replay and disarmed logging. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/36_autotune_roll_results.param |
Adds roll filter and slew settings. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/33_evaluate_the_aircraft_tune_ff_disable.param |
Adjusts batch logging. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/32_inflight_magnetometer_fit_results.param |
Adds third-compass calibration data. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/30_quick_tune_results.param |
Adds quick-tune controller values. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/27_pid_notch_filter_logging.param |
Updates PID notch logging. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/25_motor_notch_filter_results.param |
Updates motor notch settings. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/24_throttle_controller.param |
Updates voltage and throttle-control values. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/22_motor_notch_logging.param |
Clarifies logging configuration. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/21_motor_notch_filter_setup.param |
Adds notch frequency ratio. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/20_esc.param |
Assigns motor servo functions. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/18_osd.param |
Updates OSD configuration. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/16_safety_setup.param |
Updates fence, failsafe, and safety settings. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/15_general_configuration.param |
Updates EKF and RTL configuration. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/12_gnss.param |
Disables unused serial protocol. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/11_battery.param |
Moves board type configuration. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/10_battery_monitor.param |
Adds board type configuration. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/07_remote_controller_controller.param |
Adds RC calibration values. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/06_remote_controller_receiver.param |
Adds throttle failsafe value. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/04_imu_temperature_calibration_finish.param |
Stops disarmed logging. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/02_imu_temperature_calibration_setup.param |
Removes the board heater target. |
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/00_default.param |
Limits EKF to IMU 1. |
Review details
Suppressed comments (2)
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/30_quick_tune_results.param:15
- This new quick-tune value is not reflected at the
30_quick_tune_results.paramcolumn intuning_report.csv:ATC_RAT_YAW_FLTEremains forward-filled as 2.0 until the later40_autotune_yaw_results.paramcolumn. The tuning report therefore shows the wrong value for the quick-tune step; add 2.090602 to that row's 30-column (and keep the later columns consistent).
ATC_RAT_YAW_FLTE,2.090602
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/tuning_report.csv:1
- The new
30_quick_tune_results.paramsetsATC_RAT_YAW_FLTEto2.090602, but this report row leaves the new step-30 column empty and only records that value at step 40. Because the report loader forward-fills empty cells, the tuning graph shows2.0through Quick Tune instead of the value actually applied at that step; populate the step-30 cell as well.
param,00_default.param,13_initial_atc.param,23_optional_pid_adjustment.param,30_quick_tune_results.param,36_autotune_roll_results.param,38_autotune_pitch_results.param,40_autotune_yaw_results.param,42_autotune_yawd_results.param,44_autotune_roll_pitch_retune_results.param
- Files reviewed: 24/24 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ATC_ANG_PIT_P,4.5,24.62969398498535,5.4,,,24.629694,,,24.629694 | ||
| ATC_ANG_RLL_P,4.5,18.379056930541992,5.4,,18.379057,,,,18.379057 |
Description
Update the x500 template
Checklist
git commit --signoff)Testing
Describe how you tested these changes: