Skip to content

chore(x500): Update the x500 template - #2067

Merged
amilcarlucas merged 2 commits into
masterfrom
update_x500
Sep 14, 2026
Merged

amilcarlucas merged 2 commits into
masterfrom
update_x500

Conversation

@amilcarlucas

Copy link
Copy Markdown
Collaborator

Description

Update the x500 template

Checklist

  • Run pre-commit checks locally
  • Verified by a human programmer
  • All commits are signed off (use git commit --signoff)
  • Code follows our coding standards
  • Documentation updated if needed
  • No breaking changes or properly documented

Testing

Describe how you tested these changes:

  • Unit tests pass
  • Integration tests pass
  • Manual testing performed
  • Tested on flight controller hardware

Copilot AI lite review requested due to automatic review settings September 14, 2026 10:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Moderate tuning-report consistency findings remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Updates the Holybro X500 ArduCopter 4.6.3 vehicle template with refreshed metadata, configuration, calibration, filtering, and tuning results.

Changes:

  • Updates firmware, RC, sensor, safety, and board configuration.
  • Refreshes logging, ESC, OSD, GNSS, and controller parameters.
  • Adds updated calibration, autotune, quick-tune, and tuning-report data.

Unresolved moderate findings remain in the tuning report: angle gains appear before they are applied, and ATC_RAT_YAW_FLTE=2.090602 is missing from the step-30 column.

File summaries
File Summary
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/vehicle_components.json Updates firmware and RC metadata.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/tuning_report.csv Updates tuning-step columns and values.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/53_system_id_mixer_roll.param Disables replay and disarmed logging.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/36_autotune_roll_results.param Adds roll filter and slew settings.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/33_evaluate_the_aircraft_tune_ff_disable.param Adjusts batch logging.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/32_inflight_magnetometer_fit_results.param Adds third-compass calibration data.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/30_quick_tune_results.param Adds quick-tune controller values.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/27_pid_notch_filter_logging.param Updates PID notch logging.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/25_motor_notch_filter_results.param Updates motor notch settings.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/24_throttle_controller.param Updates voltage and throttle-control values.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/22_motor_notch_logging.param Clarifies logging configuration.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/21_motor_notch_filter_setup.param Adds notch frequency ratio.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/20_esc.param Assigns motor servo functions.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/18_osd.param Updates OSD configuration.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/16_safety_setup.param Updates fence, failsafe, and safety settings.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/15_general_configuration.param Updates EKF and RTL configuration.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/12_gnss.param Disables unused serial protocol.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/11_battery.param Moves board type configuration.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/10_battery_monitor.param Adds board type configuration.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/07_remote_controller_controller.param Adds RC calibration values.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/06_remote_controller_receiver.param Adds throttle failsafe value.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/04_imu_temperature_calibration_finish.param Stops disarmed logging.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/02_imu_temperature_calibration_setup.param Removes the board heater target.
ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/00_default.param Limits EKF to IMU 1.
Review details

Suppressed comments (2)

ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/30_quick_tune_results.param:15

  • This new quick-tune value is not reflected at the 30_quick_tune_results.param column in tuning_report.csv: ATC_RAT_YAW_FLTE remains forward-filled as 2.0 until the later 40_autotune_yaw_results.param column. The tuning report therefore shows the wrong value for the quick-tune step; add 2.090602 to that row's 30-column (and keep the later columns consistent).
ATC_RAT_YAW_FLTE,2.090602

ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/tuning_report.csv:1

  • The new 30_quick_tune_results.param sets ATC_RAT_YAW_FLTE to 2.090602, but this report row leaves the new step-30 column empty and only records that value at step 40. Because the report loader forward-fills empty cells, the tuning graph shows 2.0 through Quick Tune instead of the value actually applied at that step; populate the step-30 cell as well.
param,00_default.param,13_initial_atc.param,23_optional_pid_adjustment.param,30_quick_tune_results.param,36_autotune_roll_results.param,38_autotune_pitch_results.param,40_autotune_yaw_results.param,42_autotune_yawd_results.param,44_autotune_roll_pitch_retune_results.param
  • Files reviewed: 24/24 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +5 to +6
ATC_ANG_PIT_P,4.5,24.62969398498535,5.4,,,24.629694,,,24.629694
ATC_ANG_RLL_P,4.5,18.379056930541992,5.4,,18.379057,,,,18.379057
@amilcarlucas
amilcarlucas merged commit 7b6656e into master Sep 14, 2026
7 of 8 checks passed
@amilcarlucas
amilcarlucas deleted the update_x500 branch September 14, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants