Repository navigation
Run offline placeholder lookups off the Minecraft main thread - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bukkit.getOfflinePlayer(UUID)directly on the Spark/Jetty request workerPlaceholderAPI.setPlaceholders(...)on the same worker instead of scheduling onto the Bukkit main threadmax-concurrentsemaphore as the concurrency boundRationale
Spark already dispatches HTTP routes on its Jetty worker pool. Scheduling every REST lookup back onto the Bukkit scheduler serialized placeholder evaluation onto the server tick thread and made offline lookups contribute directly to tick latency.
This change reuses the existing Spark worker pool rather than introducing an additional executor or virtual-thread layer.
Compatibility
PlaceholderAPI expansions queried through this endpoint must support off-thread execution. PlaceholderAPI invokes expansion code synchronously and does not make third-party expansions thread-safe automatically.
Existing configurations containing
timeout-msremain loadable; the key is simply no longer used.Validation
GitHub Actions runs
bash gradlew test shadowJar --no-daemonon JDK 25.