Skip to content

(fix): ensure anon functions don't get misclassed as reactive calls #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashbaldry merged 2 commits into from
Sep 17, 2026
Merged

(fix): ensure anon functions don't get misclassed as reactive calls #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dd596a
(fix): ensure anon functions don't get misclassed as reactive calls
ashbaldry Sep 17, 2026
93e0271
(fix): 0-arg function calls no longer classed as reactives
ashbaldry Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions R/call_chunk_utils.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,12 @@
#' @keywords internal
#' @rdname call_chunk_checks
is_reactive_call <- function(x, env = rlang::caller_env()) {
rlang::is_call(x) &&
call_name <- if (rlang::is_call(x)) rlang::call_name(x)

!is.null(call_name) &&
length(rlang::call_args(x)) == 0 &&
rlang::call_name(x) %in% names(env)
call_name %in% names(env) &&
inherits(env[[call_name]], "reactive")
}

#' @description
Expand All @@ -39,10 +42,12 @@ is_reactive_val_call <- function(x, env = rlang::caller_env()) {
#'
#' @rdname call_chunk_checks
is_reactive_val_setter_call <- function(x, env = rlang::caller_env()) {
rlang::is_call(x) &&
call_name <- if (rlang::is_call(x)) rlang::call_name(x)

!is.null(call_name) &&
length(rlang::call_args(x)) == 1L &&
rlang::call_name(x) %in% names(env) &&
inherits(env[[rlang::call_name(x)]], "reactiveVal")
call_name %in% names(env) &&
inherits(env[[call_name]], "reactiveVal")
}

#' @description
Expand Down
32 changes: 32 additions & 0 deletions tests/testthat/test-call_chunk_utils.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,35 @@ test_that("Able to extract package name from unnamespaced function call", {
test_that("When extract package from function call, base R packages are ignored", {
expect_null(get_pkg_name(str2lang("nzchar('foo')")))
})

test_that("Call checks return FALSE, not NA, when the call has no function name", {
anon_call <- str2lang('get("mean")(1:10)')

expect_false(is_reactive_call(anon_call))
expect_false(is_reactive_val_call(anon_call))
expect_false(is_reactive_val_setter_call(anon_call))
})

test_that("A reactive calling an unnamed function is reproduced rather than erroring", {
testthat::skip_if_not_installed("shiny")

shiny::reactiveConsole(TRUE)
on.exit(shiny::reactiveConsole(FALSE), add = TRUE)

named_fn <- shiny::reactive(get("mean")(1:10))
expect_identical(reprex_reactive(named_fn), 'get("mean")(1:10)')

anon_fn <- shiny::reactive((function(x) x + 1)(1))
expect_identical(reprex_reactive(anon_fn), "(function(x) x + 1)(1)")
})

# is_reactive_call ----
test_that("A function call with no arguments is not classed as a reactive", {
testthat::skip_if_not_installed("shiny")

my_fn <- function() "hello"
my_reactive <- shiny::reactive("")

expect_false(is_reactive_call(quote(my_fn())))
expect_true(is_reactive_call(quote(my_reactive())))
})
Loading