Fix CLI metadata startup loading in WebContainers#3029
Conversation
|
Wouldn't the underlying problem still be present when you try to compile something? Also, from my testing, I think the issue is that StackBlitz doesn't properly support |
|
@CountBleck The first version only avoided loading the compiler/Binaryen for metadata-only exits, so yes, an actual compile could still hit the same broken startup wasm path. I pushed a follow-up in I also added browser regression coverage that patches |
Hmm, I'm not sure we should provide compile streaming fallback from our side. It's much better to have the environment load the polyfill if it really required this by itself. For example use this one: https://www.npmjs.com/package/wasm-instantiate-streaming |
Fixes #3027.
Summary
instantiateStreamingfallback while loading compiler startup dependencies, so environments with broken streaming support can still compileinstantiateStreamingValidation