Skip to content

fix(version): harden java version check by using Runtime class - #30

Merged
AtesComp merged 1 commit into
AtesComp:mainfrom
FredPraca:fix/harden_java_version_check
Sep 15, 2026
Merged

AtesComp merged 1 commit into
AtesComp:mainfrom
FredPraca:fix/harden_java_version_check

Conversation

@FredPraca

Copy link
Copy Markdown
Contributor

On Manjaro, using java.version returns more than two digits in version number.
Using strJVMVersion.lastIndexOf('.') to get the major version as substring returns a not parseable number triggering NumberFormatException.
For example, I currently run openjdk 21.0.12.1 2026-08-18, so the current algorithm returns 21.0.12 as major version.

Using Runtime.version() is more stable and provide all version numbers already typed.

@AtesComp

Copy link
Copy Markdown
Owner

Look eminently reasonable and straight forward to me.

@AtesComp
AtesComp merged commit 62fe144 into AtesComp:main Sep 15, 2026
1 check passed
@AtesComp

Copy link
Copy Markdown
Owner

I'll need to package an updated release, but at least it's in the code. I do see the irony in doing a version release for proper version checking.

@FredPraca

Copy link
Copy Markdown
Contributor Author

I didn't see it this way but you're right, that's quite ironic 😁
But you merged it so fast, that nobody will remember this 😉

@FredPraca
FredPraca deleted the fix/harden_java_version_check branch September 15, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants