Repository navigation
Add proxy support for WKWebView #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
KodamaSakuno
wants to merge
1
commit into
AvaloniaUI:main
Choose a base branch
from
KodamaSakuno:webkit-proxy-feature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
src/Avalonia.Controls.WebView.Core/Macios/Interop/NetworkFramework.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| using System; | ||
| using System.Runtime.InteropServices; | ||
|
|
||
| namespace Avalonia.Controls.Macios.Interop; | ||
|
|
||
| internal static partial class NetworkFramework | ||
| { | ||
| private const string Framework = "/System/Library/Frameworks/Network.framework/Network"; | ||
|
|
||
| [LibraryImport(Framework)] | ||
| public static partial IntPtr nw_endpoint_create_host( | ||
| [MarshalAs(UnmanagedType.LPStr)] string host, | ||
| [MarshalAs(UnmanagedType.LPStr)] string port); | ||
|
|
||
| [LibraryImport(Framework)] | ||
| public static partial IntPtr nw_proxy_config_create_http_connect(IntPtr endpoint, IntPtr tlsOptions); | ||
| [LibraryImport(Framework)] | ||
| public static partial IntPtr nw_proxy_config_create_socksv5(IntPtr endpoint); | ||
|
|
||
| [LibraryImport(Framework)] | ||
| public static partial IntPtr nw_tls_create_options(); | ||
|
|
||
| [LibraryImport(Framework)] | ||
| public static partial void nw_proxy_config_add_excluded_domain(IntPtr config, [MarshalAs(UnmanagedType.LPStr)] string excludedDomain); | ||
|
|
||
| [LibraryImport(Framework)] | ||
| public static partial void nw_proxy_config_set_username(IntPtr config, [MarshalAs(UnmanagedType.LPStr)] string username); | ||
|
|
||
| [LibraryImport(Framework)] | ||
| public static partial void nw_proxy_config_set_password(IntPtr config, [MarshalAs(UnmanagedType.LPStr)] string password); | ||
|
|
||
| [LibraryImport(Framework)] | ||
| public static partial void nw_release(IntPtr obj); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's not typically recommended to reuse types across domains, just because they fit similarly.
But what do you think of using .NET's
WebProxytype here?WebProxy has Address, BypassList and Credentials (
proxy.Credentials.GetCredentials("Basic")) that cover these three config properties.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me,
WebProxyis suitable here. I need to test its behavior.