Improve caching behavior. - #38
Open
avlcodemonkey wants to merge 2 commits into
Open
avlcodemonkey wants to merge 2 commits into
avlcodemonkey wants to merge 2 commits into
Conversation
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Refresh cadence can exceed the documented interval, and the new request-timeout behavior lacks deterministic coverage.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Introduces background feature-definition refreshes so request-time flag checks use a last-known-good in-memory snapshot without HTTP latency.
Changes:
- Adds a hosted refresh service with atomic snapshot replacement and failure recovery.
- Updates client registration, cache semantics, documentation, and package version.
- Replaces cache-focused tests with background-refresh coverage.
| File | Description |
|---|---|
src/FeatureFlags.Client/IFeatureFlagClient.cs |
Documents snapshot and refresh semantics. |
src/FeatureFlags.Client/HttpFeatureFlagClient.cs |
Reads from the maintained snapshot. |
src/FeatureFlags.Client/FeatureFlags.Client.csproj |
Bumps package version. |
src/FeatureFlags.Client/FeatureDefinitionRefreshService.cs |
Implements hosted background refreshing. |
src/FeatureFlags.Client/Extensions.cs |
Registers the refresh service. |
src/FeatureFlags.Client.Tests/HttpFeatureFlagClientTests.cs |
Removes obsolete cache tests. |
src/FeatureFlags.Client.Tests/FeatureDefinitionRefreshServiceTests.cs |
Tests refresh and recovery behavior. |
src/FeatureFlags.Client.Tests/ExtensionsTests.cs |
Verifies hosted-service registration. |
README.md |
Documents the new caching model. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: avlcodemonkey <6305631+avlcodemonkey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.