Harden SentinelML monitoring pipeline, API, and regression checks - #1
Merged
Merged
Conversation
Ayushdevo
commented
Sep 29, 2026
Ayushdevo
left a comment
Owner
Author
There was a problem hiding this comment.
Post-merge code review: the hardening work improved startup safety, schema checks, PSI handling, and regression coverage. I found three operational gaps worth following up:
- #2 —
/readyvalidates artifact existence, not loadability/parsing, so corrupt artifacts can still report ready. - #3 —
load_model()is process-cached indefinitely; replacing the model artifact can leave inference serving the stale model. - #4 — drift detection catches missing expected features but silently ignores unexpected production-only columns, which can hide schema drift.
These are follow-up improvements rather than reasons to revert the merged hardening PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch contains 30 focused commits. The final Git tree was verified to match the locally tested checkout.
Verification
.venv/bin/python -m src.run_pipelinecompleted with existing sample data/model artifacts..venv/bin/python -m pytest -q: 9 passed.The generated report artifacts were restored after verification and are not included in the change.