fix: keep acir components missing-witness test valid#24985
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the nightly debug build failure from run 30190352077. The public CI dashboard child log is 1785045829822368, and the failing test log is a58e3ea4c384e87e.
Root cause:
AcirComponentsCheckTest.DetectsUnconstrainedWitnessestried to simulate a missing circuit witness by shrinkingbuilder.real_variable_index. In the debug preset,_GLIBCXX_DEBUGcatches the resulting internally inconsistent builder beforeComponentsCheckerreaches its own missing-witness classification:StaticAnalyzerwalks the existing gates and indexes witness10in a 9-elementreal_variable_indexvector.Change: keep the builder internally valid, then pass
ComponentsCheckera copied ACIR circuit whose graph references witness999. That still exercises the intendedUNCONSTRAINEDpath, but no longer corrupts the builder object that the shared static analyzer must process.Validation:
./build-debug/bin/acir_components_check_tests --gtest_filter=AcirComponentsCheckTest.DetectsUnconstrainedWitnessesexited 134 with the same_GLIBCXX_DEBUGvector bounds abort.cmake --preset debugcmake --build build-debug --target acir_components_check_tests./build-debug/bin/acir_components_check_tests --gtest_filter=AcirComponentsCheckTest.DetectsUnconstrainedWitnesses./build-debug/bin/acir_components_check_testsCreated by claudebox · group:
slackbot