Skip to content

Peg package versions in project files #127

Description

@guardrex

Owen Richards (@OwenRichards1) ... Hello! I was checking some cross-links in the ASP.NET Core docs, and I noticed that several Azure samples (in different repos) are floating versions against our best practices guidelines ...

https://github.com/search?q=repo%3AAzure-Samples%2Fms-identity-docs-code-dotnet+%22.*\%22%22&type=code

One of them ... the one that I was checking a cross-link on ... is one that you performed an upgrade on ...

https://github.com/Azure-Samples/ms-identity-docs-code-dotnet/blob/main/spa-blazor-wasm/BlazorWasm.csproj

Would you (or someone) mind pegging the package refs to "8.0.0." I realize that there's no 8.1 (and likely never going to be one) and that floating will just roll-forward the patch release. However, patches roll forward automatically anyway, and we (on the ASP.NET Core engineering side) don't recommend showing devs samples that adopt the practice of floating versions due to stability/security concerns. We consider it a dangerous habit to form.

In addition to that sample, we'd like to get the others updated as well to patch to their floating package versions. They lie across different repos, and I'm not sure if one person can update all four of them based on this one issue or if three more issues should be opened (one on each of the other three sample repos).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions