Skip to content

feat: pre-pull networking images from LPS - #9727

Draft
Mugesh (mugeshsp) wants to merge 3 commits into
mainfrom
mugeshsp/lps-networking-image-cache-classic-signed
Draft

Mugesh (mugeshsp) wants to merge 3 commits into
mainfrom
mugeshsp/lps-networking-image-cache-classic-signed

Conversation

@mugeshsp

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Adds a fail-open, pre-kubelet networking image cache path driven by the exact image references returned by Live Patching Service (LPS).

  • Generalizes the existing LPS client to fetch the networkingImageCache component while preserving hotfix behavior.
  • Adds prepull-networking-images with schema/pool validation, deterministic deduplication, bounded concurrency and timeouts, telemetry, and an atomic status artifact.
  • Extends image-fetcher to verify exact containerd content and unpack state, unpack locally available images, or pull and unpack missing content.
  • Delivers the feature through classic cloud-init after containerd is healthy and immediately before kubelet starts.

Validation performed:

  • AgentBaker node-controller and image-fetcher unit tests passed.
  • Targeted networking cache tests passed with the Go race detector.
  • ShellSpec passed 43/43 assertions, including containerd -> pre-pull -> kubelet ordering and fail-open behavior.
  • Standalone private-VHD acceptance and 10-iteration runs validated exact payload/render parity, pre-kubelet completion, and zero Cilium/CNS runtime pulls on retained nodes.

Which issue(s) this PR fixes:

Fixes #

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Windows Unit Test Results

  3 files   18 suites   1m 18s ⏱️
662 tests 662 ✅ 0 💤 0 ❌
685 runs  685 ✅ 0 💤 0 ❌

Results for commit bc6a695.

♻️ This comment has been updated with latest results.

Mugesh (mugeshsp) and others added 2 commits October 28, 2026 12:50
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: d1d36a37-0776-43d8-993f-251e8f6fefb9
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: d1d36a37-0776-43d8-993f-251e8f6fefb9
@mugeshsp
Mugesh (mugeshsp) force-pushed the mugeshsp/lps-networking-image-cache-classic-signed branch 2 times, most recently from 492605a to 5071d17 Compare October 28, 2026 21:10
Consume schema-v2 per-agent-pool inventories from LPS, pre-pull and unpack networking images before kubelet startup, and preserve strict fail-open behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: d1d36a37-0776-43d8-993f-251e8f6fefb9
@mugeshsp
Mugesh (mugeshsp) force-pushed the mugeshsp/lps-networking-image-cache-classic-signed branch from 5071d17 to bc6a695 Compare October 28, 2026 22:03
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
test 0% ❌
windows 27% ❌
staging_cse_windows Package 1 68% ➖
debug 0% ❌
provisioningscripts 2% ❌
parts_windows Package 1 73% ➖
Summary 39% (1819 / 7001) ❌

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
github.com/Azure/agentbaker/aks-node-controller 73% ➖
github.com/Azure/agentbaker/aks-node-controller/common 100% ✔
github.com/Azure/agentbaker/aks-node-controller/helpers 68% ➖
github.com/Azure/agentbaker/aks-node-controller/parser 88% ✔
github.com/Azure/agentbaker/aks-node-controller/pkg/gpu 100% ✔
github.com/Azure/agentbaker/aks-node-controller/pkg/nodeconfigutils 89% ✔
github.com/Azure/agentbaker/aks-node-controller/utils 0% ❌
github.com/Azure/agentbaker/apiserver 24% ❌
github.com/Azure/agentbaker/cmd 0% ❌
github.com/Azure/agentbaker/cmd/starter 0% ❌
github.com/Azure/agentbaker/fuzz/api 0% ❌
github.com/Azure/agentbaker/hotfix/render-nodecustomdata 35% ❌
github.com/Azure/agentbaker/pkg/agent 78% ➖
github.com/Azure/agentbaker/pkg/agent/datamodel 77% ➖
github.com/Azure/agentbaker/pkg/agent/toggles 0% ❌
github.com/Azure/agentbaker/pkg/vhdbuilder/datamodel 87% ✔
Summary 75% (6244 / 8283) ➖

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Health
shellspec spec 29% ❌
Summary 29% (4699 / 16380) ❌

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant