[Cameron Meissner (cameronmeissner)]

What this PR does / why we need it:

move cgroup telemetry enablement and startup to nodePrep, rather than during the VHD build - we don't need telemetry during builds - this will also fix

Which issue(s) this PR fixes:

Fixes #

[github-actions]

Windows Unit Test Results

  3 files   18 suites   1m 16s ⏱️
662 tests 662 ✅ 0 💤 0 ❌
685 runs  685 ✅ 0 💤 0 ❌

Results for commit f90e630.

♻️ This comment has been updated with latest results.

[Copilot]

🟢 Approval recommended

No active review issues remain for the telemetry cleanup change.

No open issues 🎉

What changed in this PR

This PR adjusts telemetry cleanup during Linux VHD builds to address intermittent failures after cgroup telemetry configuration.

Changes:

• Changes CustomScript log-directory removal from rm -r to rm -rf.
• Preserves the existing cleanup condition and failure handling.

File	Description
vhdbuilder/​packer/​install-dependencies.sh	Adds force mode to CustomScript log cleanup after telemetry configuration.

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

The telemetry cleanup change has no active review issues.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Missing timeout arguments in three service calls produce invalid timeout systemctl commands, exhausting retries and causing provisioning failures on affected Linux distributions.

1 open issue

• Add required timeout to service calls · New

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Three service startup calls omit required timeout arguments, causing repeated command failures and aborting node provisioning with exit code 247.

No open issues 🎉

1 resolved since last review

• Add required timeout to service calls

_{Review effort: Balanced}

[github-actions]

Package	Line Rate	Health
test	0%	❌
windows	27%	❌
staging_cse_windows Package 1	68%	➖
debug	0%	❌
provisioningscripts	2%	❌
parts_windows Package 1	73%	➖
Summary	39% (1819 / 7001)	❌

[github-actions]

Package	Line Rate	Health
shellspec spec	29%	❌
Summary	29% (4707 / 16475)	❌

[github-actions]

Package	Line Rate	Health
github.com/Azure/agentbaker/aks-node-controller	73%	➖
github.com/Azure/agentbaker/aks-node-controller/common	100%	✔
github.com/Azure/agentbaker/aks-node-controller/helpers	68%	➖
github.com/Azure/agentbaker/aks-node-controller/parser	88%	✔
github.com/Azure/agentbaker/aks-node-controller/pkg/gpu	100%	✔
github.com/Azure/agentbaker/aks-node-controller/pkg/nodeconfigutils	89%	✔
github.com/Azure/agentbaker/aks-node-controller/utils	0%	❌
github.com/Azure/agentbaker/apiserver	24%	❌
github.com/Azure/agentbaker/cmd	0%	❌
github.com/Azure/agentbaker/cmd/starter	0%	❌
github.com/Azure/agentbaker/fuzz/api	0%	❌
github.com/Azure/agentbaker/hotfix/render-nodecustomdata	35%	❌
github.com/Azure/agentbaker/pkg/agent	78%	➖
github.com/Azure/agentbaker/pkg/agent/datamodel	77%	➖
github.com/Azure/agentbaker/pkg/agent/toggles	0%	❌
github.com/Azure/agentbaker/pkg/vhdbuilder/datamodel	87%	✔
Summary	75% (6023 / 7989)	➖

[Copilot]

🟢 Approval recommended

No active review issues were identified for the change moving Linux cgroup telemetry startup from image building to node provisioning.

No open issues 🎉

_{Review effort: Balanced}