Repository navigation
test: add minification verification test - #9945
Merged
Merged
Conversation
Contributor
Windows Unit Test Results 3 files 18 suites 1m 17s ⏱️ Results for commit 2b3b9f3. ♻️ This comment has been updated with latest results. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the minification review-artifact and Bash syntax-check changes.
No open issues 🎉
What changed in this PR
Adds reviewable artifacts and Bash syntax checks for AgentBaker’s provisioning-script minification, without changing production behavior.
Changes:
- Adds an opt-in Go test exporting rendered scripts, minified payloads, and diffs across six OS variants and public/custom cloud fixtures.
- Enables artifact generation in the Go unit-test workflow and uploads results with five-day retention.
- Documents local generation and clarifies that syntax checks do not prove semantic equivalence.
| File | Description |
|---|---|
vhdbuilder/packer/README.md |
Documents artifact generation, fixture coverage, and verification limits. |
pkg/agent/script_minification_artifacts_test.go |
Exports before/after scripts and diffs, and checks Bash syntax. |
.github/workflows/go-test.yml |
Enables artifact generation and uploads minification diffs. |
Review effort: Balanced
Nishchay (awesomenix)
enabled auto-merge (squash)
October 28, 2026 21:47
Contributor
|
Contributor
|
Contributor
|
Cameron Meissner (cameronmeissner)
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add minification verfification test