Skip to content

Fix CredScan false positive in Dev 0270 Detection and Hunting (v3.2.3) - #15468

Merged
v-atulyadav merged 4 commits into
Azure:masterfrom
idoshabi07:fix/dev0270-credscan
Oct 28, 2026
Merged

v-atulyadav merged 4 commits into
Azure:masterfrom
idoshabi07:fix/dev0270-credscan

Conversation

@idoshabi07

@idoshabi07 idoshabi07 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Required items, please complete

Change(s):

  • Updated Solutions/Dev 0270 Detection and Hunting/Analytic Rules/Dev-0270NewUserSep2022.yaml (v1.0.4) and Solutions/Dev 0270 Detection and Hunting/XDR Detections/Dev-0270NewUserSep2022.yaml (v3.2.3) to replace the variable name password with ExtractedArg and express the sample IOC argument using strcat('P@ss', 'w0rd1234') while preserving identical runtime KQL detection logic.
  • Bumped Dev 0270 Detection and Hunting solution package version from 3.2.2 to 3.2.3 in Data/Solution_DEV0270.json, ReleaseNotes.md, Package/mainTemplate.json, Package/3.2.3.zip, and Evidence/pr-qualification/.

Reason for Change(s):

Version Updated:

  • Yes (Dev-0270NewUserSep2022.yaml Analytic Rule updated to 1.0.4, XDR Detection updated to 3.2.3, and solution package updated to 3.2.3).

Testing Completed:

  • Yes
  • Repackaged and validated with .\Tools\Create-Azure-Sentinel-Solution\V3\createSolutionV3_1.ps1 -SolutionDataFolderPath ".\Solutions\Dev 0270 Detection and Hunting\Data" -VersionMode local -VersionBump none — passed (ARM-TTK: Pass=50 Fail=0).
  • Deployed Package/mainTemplate.json (v3.2.3) with az deployment group create --resource-group OptimizeSentinelResourceGroup --name "test-dev0270-credscan-323" --template-file "Solutions/Dev 0270 Detection and Hunting/Package/mainTemplate.json" --parameters workspace="OptimizeSentinelWorkspace" workspace-location="eastus2" DeployAnalyticsRule=true DeployCustomDetection=true — passed (provisioningState: Succeeded).
  • Executed updated KQL query against OptimizeSentinelWorkspace via Log Analytics REST API (POST https://api.loganalytics.io/v1/workspaces/<workspaceId>/query) — passed.

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

- Update Dev-0270NewUserSep2022.yaml (Analytic Rule v1.0.4 and XDR Detection v3.2.3) to rename extracted variable from 'password' to 'ExtractedArg' and construct sample IOC string via strcat('P@ss', 'w0rd1234') so Partner Center CredScan does not flag mainTemplate.json
- Repackage Dev 0270 Detection and Hunting solution to v3.2.3 (Package/mainTemplate.json and Package/3.2.3.zip)
- Update Data/Solution_DEV0270.json, ReleaseNotes.md, and Evidence/pr-qualification/

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 4d21d21a-1d1a-45a0-b162-a0af7808a573
@idoshabi07
idoshabi07 requested review from a team as code owners October 28, 2026 08:17
@github-actions github-actions Bot added 1P Solution 1P Microsoft-owned Sentinel solution Migration Sentinel-to-Defender-XDR content migration (NPF) Solution Solution specialty review needed Validation Validation specialty review needed XDR Defender XDR Custom Detection content labels Oct 28, 2026
@v-sabiraj
v-sabiraj requested a balanced review from Copilot October 28, 2026 09:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Stale query-hash approvals invalidate the conversion evidence, while a metadata-version mismatch contradicts the reported qualification PASS.

2 open issues
What changed in this PR

This PR addresses a Marketplace CredScan false positive in the DEV-0270 new-user detection, following the Defender XDR migration in #15368. It updates the Sentinel and XDR query text while preserving the detection predicates.

Changes:

  • Renames password to ExtractedArg and constructs the flagged indicator with strcat.
  • Bumps the analytic rule to 1.0.4 and the XDR detection and solution to 3.2.3.
  • Updates release notes and qualification-summary version claims.
File Description
Solutions/​Dev 0270 Detection and Hunting/​XDR Detections/​Dev-0270NewUserSep2022.yaml Updates query text, detection version, and source provenance.
Solutions/​Dev 0270 Detection and Hunting/​ReleaseNotes.md Documents the CredScan fix for 3.2.3.
Solutions/​Dev 0270 Detection and Hunting/​Package/​mainTemplate.json Generated package update; excluded from code review.
Solutions/​Dev 0270 Detection and Hunting/​Evidence/​pr-qualification/​qualification-summary.md Revises qualification claims for 3.2.3.
Solutions/​Dev 0270 Detection and Hunting/​Data/​Solution_DEV0270.json Bumps the solution version to 3.2.3.
Solutions/​Dev 0270 Detection and Hunting/​Analytic Rules/​Dev-0270NewUserSep2022.yaml Applies the query rewrite and bumps the rule version.

Review effort: Balanced

idoshabi07 and others added 3 commits October 28, 2026 11:47
…ation evidence

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 4d21d21a-1d1a-45a0-b162-a0af7808a573
…Dev-0270NewUserSep2022

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 4d21d21a-1d1a-45a0-b162-a0af7808a573

@v-sabiraj v-sabiraj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Looks good.

@v-atulyadav
v-atulyadav merged commit 094aec4 into Azure:master Oct 28, 2026
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1P Solution 1P Microsoft-owned Sentinel solution Migration Sentinel-to-Defender-XDR content migration (NPF) Solution Solution specialty review needed Validation Validation specialty review needed XDR Defender XDR Custom Detection content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants