Repository navigation
Fix EmailEvent recipient array element types in ASIM catalog - #15487
adbhogeGit wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the scoped EmailEvent recipient-array metadata change.
No open issues 🎉
What changed in this PR
Corrects recipient-array metadata in the shared ASIM validation catalog so arrays of strings can pass element-type validation. This publishes the catalog fix independently of the Proofpoint parser work in #15464.
Changes:
- Sets
ArrayValuesType=stringforEmailToRecipients,EmailCCRecipients, andEmailBCCRecipients, scoped toEmailEvent. - Leaves parser implementations and validation tooling unchanged.
| File | Description |
|---|---|
ASIM/dev/ASimTester/ASimTester.csv |
Declares string element types for the three EmailEvent recipient arrays. |
Review effort: Balanced
|
Suppose the counterpart QTP of ASimEmailEventProofpointPODMessage should also failed for the same ASimDataTester's test? Derrick Lee (@yummyblabla) Could you take a look at this PR and the test of the ITP flow: https://github.com/Azure/Azure-Sentinel/actions/runs/40780599305 |
|
Closing because the original ASimDataTester validation failure was fixed by merged PR #15498: #15498 . The tester now skips array-element type checks when ArrayValuesType is unspecified, so this separate metadata change is no longer needed to unblock the parser. Message PR #15464 subsequently passed its full canary validation: https://github.com/Azure/Azure-Sentinel/actions/runs/40981833569 . |
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
git -c core.whitespace=cr-at-eol --no-pager diff --check origin/master...HEAD. Plain whitespace checks flag the existing CRLF style;git ls-files --eol -- ASIM/dev/ASimTester/ASimTester.csvconfirms both index and working file use CRLF.& .\ASIM\dev\ASimTester\Validate-ASimCsv\Validate-ASimCsv.ps1 -FilesPath .\ASIM\dev\ASimTester\ASimTester.csvexits 1 with "The file 'ASimTester' is not valid". Its required-header list contains seven columns, while the existing catalog contains nine, including DynamicType and ArrayValuesType. Validator left unchanged; updating it requires a separate maintainer task.Checked that the validations are passing and have addressed any issues that are present: