Skip to content

fix(vscode): Fix invalid workflow-designtime artifacts path with symlink - #9501

Open
Andrew Eldridge (andrew-eldridge) wants to merge 1 commit into
mainfrom
aeldridge/vscode-local-artifacts-fix
Open

fix(vscode): Fix invalid workflow-designtime artifacts path with symlink#9501
Andrew Eldridge (andrew-eldridge) wants to merge 1 commit into
mainfrom
aeldridge/vscode-local-artifacts-fix

Conversation

@andrew-eldridge

@andrew-eldridge Andrew Eldridge (andrew-eldridge) commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Adds symlink from projectRoot/workflow-designtime/Artifacts to projectRoot/Artifacts in design-time file consistency check to fix issue where design-time api checks for Artifacts in cwd (i.e. workflow-designtime) for dynamic list on some operations. Closes #9214

Impact of Change

  • Users: Fixes dynamic list issue in designer where artifacts don't load due to incorrect path
  • Developers: N/A
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

Andrew Eldridge (@andrew-eldridge)

@andrew-eldridge Andrew Eldridge (andrew-eldridge) added VSCode Issues or PRs specific to VS Code extension risk:low Low risk change with minimal impact labels Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Fix invalid workflow-designtime artifacts path with symlink
  • Issue: None — uses a valid fix(scope): prefix and is descriptive.
  • Recommendation: No change needed.

Commit Type

  • Exactly one type selected (fix).
  • Matches the title prefix and the nature of the change (bug fix for a broken artifacts path).

Risk Level

  • Declared Medium (body) with matching risk:medium label. This matches the advised estimate: the change is scoped to the VS Code extension distribution (apps/vs-code-designer), which is Medium per the rubric. No shipped-product security/auth or shared-core impact that would warrant High.

What & Why


Impact of Change

  • Users impact is described; Developers/System marked N/A, which is acceptable for this scoped fix.
  • Recommendation:
    • Users: Good — dynamic list artifacts now load correctly in the designer.
    • Developers: N/A is fine.
    • System: Optionally note the filesystem junction behavior on Windows vs. symlink on other platforms.

Test Plan

  • Unit tests added/updated and confirmed in the diff (new artifacts junction describe block covering create, skip, recreate, and failure cases). Satisfies CHECK TESTS.

Contributors

  • @andrew-eldridge credited.

⚠️ Screenshots/Videos

  • Not required — the diff touches apps/vs-code-designer/src (extension host/filesystem logic), not libs/designer-ui/src, libs/designer/src, or apps/vs-code-react UI components. No visual change, so no screenshots needed.

Summary Table

Section Status Recommendation
Title No change needed
Commit Type No change needed
Risk Level Medium is correct
What & Why No change needed
Impact of Change Optional: note platform junction behavior
Test Plan Unit tests confirmed in diff
Contributors No change needed
Screenshots/Videos ⚠️ Not applicable — no UI change

All required checks pass. This PR is compliant and ready to merge. Nice work including thorough unit tests for the junction logic.


Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Tue, 04 Aug 2026 16:47:17 GMT

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Check

🎉 All changed files have adequate test coverage!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an Artifacts junction for the VS Code design-time host so dynamic operations can access project artifacts.

Changes:

  • Creates or repairs the design-time Artifacts junction.
  • Adds focused junction lifecycle and failure tests.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
projectFilesConsistency.ts Ensures the design-time Artifacts junction exists.
projectFilesConsistency.test.ts Tests junction creation, repair, and failure handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:medium Medium risk change with potential impact VSCode Issues or PRs specific to VS Code extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workflow-designtime used when accessing local artifacts from VSCode

3 participants