fix(vscode): Fix invalid workflow-designtime artifacts path with symlink - #9501
Open
Andrew Eldridge (andrew-eldridge) wants to merge 1 commit into
Open
fix(vscode): Fix invalid workflow-designtime artifacts path with symlink#9501Andrew Eldridge (andrew-eldridge) wants to merge 1 commit into
Andrew Eldridge (andrew-eldridge) wants to merge 1 commit into
Conversation
Andrew Eldridge (andrew-eldridge)
requested review from
Bryan Bennett (bjbennet) and
Brian Lam (lambrianmsft)
and
a balanced review from Copilot
August 4, 2026 16:41
Copilot started reviewing on behalf of
Andrew Eldridge (andrew-eldridge)
August 4, 2026 16:41
View session
Contributor
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
✅ Contributors
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | No change needed |
| Commit Type | ✅ | No change needed |
| Risk Level | ✅ | Medium is correct |
| What & Why | ✅ | No change needed |
| Impact of Change | ✅ | Optional: note platform junction behavior |
| Test Plan | ✅ | Unit tests confirmed in diff |
| Contributors | ✅ | No change needed |
| Screenshots/Videos | Not applicable — no UI change |
All required checks pass. This PR is compliant and ready to merge. Nice work including thorough unit tests for the junction logic.
Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Tue, 04 Aug 2026 16:47:17 GMT
Contributor
📊 Coverage Check🎉 All changed files have adequate test coverage! |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an Artifacts junction for the VS Code design-time host so dynamic operations can access project artifacts.
Changes:
- Creates or repairs the design-time Artifacts junction.
- Adds focused junction lifecycle and failure tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
projectFilesConsistency.ts |
Ensures the design-time Artifacts junction exists. |
projectFilesConsistency.test.ts |
Tests junction creation, repair, and failure handling. |
This was referenced Aug 5, 2026
Brian Lam (lambrianmsft)
approved these changes
Aug 7, 2026
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
Adds symlink from projectRoot/workflow-designtime/Artifacts to projectRoot/Artifacts in design-time file consistency check to fix issue where design-time api checks for Artifacts in cwd (i.e. workflow-designtime) for dynamic list on some operations. Closes #9214
Impact of Change
Test Plan
Contributors
Andrew Eldridge (@andrew-eldridge)