fix(test): remove unnecessary test from PR749 - #750
Merged
Merged
Conversation
Co-authored-by: Zefty <25576710+Zefty@users.noreply.github.com>
Co-authored-by: Zefty <25576710+Zefty@users.noreply.github.com>
…itted Co-authored-by: Zefty <25576710+Zefty@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Jaime Wu (Zefty)
October 5, 2026 01:01
View session
Jaime Wu (Zefty)
marked this pull request as ready for review
October 5, 2026 01:01
… regression TestGetContextFromReaderUntarsDeviceNode was added in #749 to mirror the go-archive v0.3.3 release note about device nodes (moby/go-archive#103), but it does not exercise that bug. The v0.3.0 regression only fails when opening the device node fails while applying its mode (for example on a nodev mount); extracting dev/ptmx into a normal temp directory succeeds on both v0.3.0 and v0.3.3, so the test passes against the buggy version. It also needs CAP_MKNOD, so it either skipped or failed on the non-root ADO agent, and its mknod probe tripped gosec G115 (uint64 -> int). The implied-parent, absolute-symlink and absolute-hardlink tests added in #749 do fail on the affected go-archive versions and are kept. Co-authored-by: Zefty <25576710+Zefty@users.noreply.github.com>
Jaime Wu (Zefty)
changed the title
Jaime Wu (Zefty)
changed the title
Anthony Giang (anthony-giang)
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Previous PR added test for v0.3.3: "device nodes, including … dev/ptmx" which requires running test as root so fails in the pipeline. The test isn't really necessary anyways since it doesn't actually test for the breaking tar scenario.
Ran test on branch: https://dev.azure.com/azurecontainerregistry/acr-builder/_build/results?buildId=3763&view=results