Skip to content

fix(ci): authenticate after builds before publishing images #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sulixu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ci): authenticate after builds before publishing images #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 46 additions & 19 deletions .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,25 +70,34 @@ jobs:
run: |
echo "version is $VERSION"
echo "version is $VERSION_TAG"
- name: 'Build image'
env:
DRIVER_VERSION: ${{ steps.load_config.outputs.cuda_version }}
IMAGE_REPO: ${{ matrix.image_repo }}
REGISTRY_SERVER: ${{ secrets.AZURE_REGISTRY_SERVER }}
VERSION: ${{ steps.semver.outputs.version }}
run: |
set -x
echo "tag is: "
echo "$VERSION"
image_ref="${REGISTRY_SERVER}/public/aks/${IMAGE_REPO}:${VERSION}"
docker buildx build --platform linux/arm64/v8,linux/amd64 --build-arg DRIVER_KIND=cuda --build-arg "DRIVER_VERSION=${DRIVER_VERSION}" --cache-from=type=local,src=/tmp/.buildx-cache --cache-to=type=local,dest=/tmp/.buildx-cache-new --output=type=docker -t "$image_ref" .
docker images
# The build can outlast the OIDC assertion. Authenticate immediately before registry login.
- name: 'Azure CLI login'
uses: azure/login@7ddb5af1ef8758cf1353cf3b42f940aee27ba21c # v3.0.2
with:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
- name: 'Build and Push'
- name: 'Push image'
env:
DRIVER_VERSION: ${{ steps.load_config.outputs.cuda_version }}
IMAGE_REPO: ${{ matrix.image_repo }}
REGISTRY_SERVER: ${{ secrets.AZURE_REGISTRY_SERVER }}
VERSION: ${{ steps.semver.outputs.version }}
run: |
set -x
echo "tag is: "
echo "$VERSION"
image_ref="${REGISTRY_SERVER}/public/aks/${IMAGE_REPO}:${VERSION}"
docker buildx build --platform linux/arm64/v8,linux/amd64 --build-arg DRIVER_KIND=cuda --build-arg "DRIVER_VERSION=${DRIVER_VERSION}" --cache-from=type=local,src=/tmp/.buildx-cache --cache-to=type=local,dest=/tmp/.buildx-cache-new --output=type=docker -t "$image_ref" .
docker images
az acr login -n "$REGISTRY_SERVER"
docker push "$image_ref"
- name: Move cache
Expand Down Expand Up @@ -144,25 +153,34 @@ jobs:
run: |
echo "version is $VERSION"
echo "version is $VERSION_TAG"
- name: 'Build image'
env:
DRIVER_VERSION: ${{ steps.load_config.outputs.cuda_version }}
IMAGE_REPO: ${{ matrix.image_repo }}
REGISTRY_SERVER: ${{ secrets.AZURE_REGISTRY_SERVER }}
VERSION: ${{ steps.semver.outputs.version }}
run: |
set -x
echo "tag is: "
echo "$VERSION"
image_ref="${REGISTRY_SERVER}/public/aks/${IMAGE_REPO}:${VERSION}"
docker buildx build --build-arg DRIVER_KIND=cuda --build-arg "DRIVER_VERSION=${DRIVER_VERSION}" --cache-from=type=local,src=/tmp/.buildx-cache --cache-to=type=local,dest=/tmp/.buildx-cache-new --output=type=docker -t "$image_ref" .
docker images
# The build can outlast the OIDC assertion. Authenticate immediately before registry login.
- name: 'Azure CLI login'
uses: azure/login@7ddb5af1ef8758cf1353cf3b42f940aee27ba21c # v3.0.2
with:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
- name: 'Build and Push'
- name: 'Push image'
env:
DRIVER_VERSION: ${{ steps.load_config.outputs.cuda_version }}
IMAGE_REPO: ${{ matrix.image_repo }}
REGISTRY_SERVER: ${{ secrets.AZURE_REGISTRY_SERVER }}
VERSION: ${{ steps.semver.outputs.version }}
run: |
set -x
echo "tag is: "
echo "$VERSION"
image_ref="${REGISTRY_SERVER}/public/aks/${IMAGE_REPO}:${VERSION}"
docker buildx build --build-arg DRIVER_KIND=cuda --build-arg "DRIVER_VERSION=${DRIVER_VERSION}" --cache-from=type=local,src=/tmp/.buildx-cache --cache-to=type=local,dest=/tmp/.buildx-cache-new --output=type=docker -t "$image_ref" .
docker images
az acr login -n "$REGISTRY_SERVER"
docker push "$image_ref"
- name: Move cache
Expand Down Expand Up @@ -226,13 +244,7 @@ jobs:
run: |
echo "version is $VERSION"
echo "version is $VERSION_TAG"
- name: 'Azure CLI login'
uses: azure/login@7ddb5af1ef8758cf1353cf3b42f940aee27ba21c # v3.0.2
with:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
- name: 'Build and Push'
- name: 'Build image'
env:
DRIVER_URL: ${{ steps.load_config.outputs.grid_url }}
DRIVER_VERSION: ${{ steps.load_config.outputs.grid_version }}
Expand All @@ -246,6 +258,21 @@ jobs:
image_ref="${REGISTRY_SERVER}/public/aks/${IMAGE_REPO}:${VERSION}"
docker buildx build --build-arg "DRIVER_URL=${DRIVER_URL}" --build-arg DRIVER_KIND=grid --build-arg "DRIVER_VERSION=${DRIVER_VERSION}" --cache-from=type=local,src=/tmp/.buildx-cache --cache-to=type=local,dest=/tmp/.buildx-cache-new --output=type=docker -t "$image_ref" .
docker images
# The build can outlast the OIDC assertion. Authenticate immediately before registry login.
- name: 'Azure CLI login'
uses: azure/login@7ddb5af1ef8758cf1353cf3b42f940aee27ba21c # v3.0.2
with:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
- name: 'Push image'
env:
IMAGE_REPO: ${{ matrix.image_repo }}
REGISTRY_SERVER: ${{ secrets.AZURE_REGISTRY_SERVER }}
VERSION: ${{ steps.semver.outputs.version }}
run: |
set -x
image_ref="${REGISTRY_SERVER}/public/aks/${IMAGE_REPO}:${VERSION}"
az acr login -n "$REGISTRY_SERVER"
docker push "$image_ref"
- name: Move cache
Expand Down
Loading