Skip to content

{MySQL} Set default value of auto_scale_iops to 'Enabled' - #34014

Open
ShawnX (ShawnXxy) wants to merge 1 commit into
Azure:devfrom
ShawnXxy:fix/mysql-import-auto-scale-iops-default
Open

ShawnX (ShawnXxy) wants to merge 1 commit into
Azure:devfrom
ShawnXxy:fix/mysql-import-auto-scale-iops-default

Conversation

@ShawnXxy

@ShawnXxy ShawnX (ShawnXxy) commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

🤖 PR Validation — ❌ Action needed

Breaking Changes Tests
❌ 1 ️✔️ 130/130
❌AzureCLI-BreakingChangeTest
❌mysql
rule cmd_name rule_message suggest_message
❌ 1010 - ParaPropUpdate mysql flexible-server import create cmd mysql flexible-server import create update parameter auto_scale_iops: updated property default from Disabled to Enabled please change property default from Enabled to Disabled for parameter auto_scale_iops of cmd mysql flexible-server import create

Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:

  • Breaking changes can only be merged during the designated breaking change window
  • A pre-announcement must be released at least one month in advance

For more details on how to introduce breaking changes, refer to the documentation: azure-cli/doc/how_to_introduce_breaking_changes.md

Related command

az mysql flexible-server import --help

Description

Addressing #32568.
The issue was introduced in #30852 where the CLIArgumentType was left unchanged when the breaking default value changes happened

Testing Guide

python -m azure.cli mysql flexible-server import create --help 2>&1 |    Select-String -Pattern '--auto-scale-iops' -Context 0,3

>     --auto-scale-iops              : Enable or disable the auto scale iops. Default value is
                                       Enabled.  Allowed values: Disabled, Enabled.  Default: Enabled.

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

@ShawnXxy
ShawnX (ShawnXxy) requested a review from a team as a code owner September 1, 2026 13:28
Copilot AI lite review requested due to automatic review settings September 1, 2026 13:28
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the az mysql flexible-server import create argument definition so the displayed default for --auto-scale-iops matches the help text and intended breaking-change default (“Enabled”), addressing the inconsistency reported in #32568.

Changes:

  • Update mysql flexible-server import create to set auto_scale_iops default to Enabled (aligning with the argument help text and mysql flexible-server create behavior).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

@yonzhan

Copy link
Copy Markdown
Collaborator

MySQL

@ShawnXxy

Copy link
Copy Markdown
Contributor Author

Yong Zhang (@yonzhan) Ethan Yang (@necusjz) could we check this so we can still checkin in October train? Thanks.

@necusjz

Copy link
Copy Markdown
Member

ShawnX (@ShawnXxy) it introduced a breaking change, is it as expected?
image

@ShawnXxy

ShawnX (ShawnXxy) commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor Author

ShawnX (ShawnX (@ShawnXxy)) it introduced a breaking change, is it as expected? image

Ethan Yang (@necusjz) The breaking-change detection is correct for the current patch. It changes the runtime default of az mysql flexible-server import create --auto-scale-iops from Disabled to Enabled, so existing commands that omit the option will behave differently. It can also cause a supplied --iops value to be ignored because autoscale becomes enabled.

PR #30852 changed the default for the normal flexible-server create command and updated the shared help text, but it did not change the import command’s runtime default. Therefore, #30852 caused the contradictory help reported in #32568, while this PR introduces the actual import behavior change.

If Enabled is the confirmed intended default for import, this should be handled as an intentional breaking change with a pre-announcement and targeted for the 2.92.0 / November 2026 breaking-change window.

@x-engineering-agent

Copy link
Copy Markdown
Contributor

Automated sensitive-information remediation ran on this pull request.

  • Detected categories: jwt, payment card
  • Replaced with typed [REDACTED:category] placeholders in: no PR metadata fields
  • Comment/review owners notified because X Engineering Agent cannot edit another user's text: ShawnX (@ShawnXxy)

X Engineering Agent does not modify source files. The PR creator must remove or replace each suspected value at the linked line:

  • No changed-file findings

If a credential was exposed, rotate or revoke it immediately. Detected values are never copied into this comment.

✅ Confirm the finding · ❌ Dispute the finding

GitHub only supports a fixed reaction set, so 👍 represents ✅ and 👎 represents ❌. The bot-created reactions are only poll choices.

@necusjz

Copy link
Copy Markdown
Member

ShawnX (ShawnX (ShawnX (@ShawnXxy))) it introduced a breaking change, is it as expected? image

The breaking-change detection is correct for the current patch. It changes the runtime default of az mysql flexible-server import create --auto-scale-iops from Disabled to Enabled, so existing commands that omit the option will behave differently. It can also cause a supplied --iops value to be ignored because autoscale becomes enabled.

PR #30852 changed the default for the normal flexible-server create command and updated the shared help text, but it did not change the import command’s runtime default. Therefore, #30852 caused the contradictory help reported in #32568, while this PR introduces the actual import behavior change.

If Enabled is the confirmed intended default for import, this should be handled as an intentional breaking change with a pre-announcement and targeted for the 2.92.0 / November 2026 breaking-change window.

so let's continue that topic on the next breaking change window.

@x-engineering-agent

Copy link
Copy Markdown
Contributor

Automated sensitive-information remediation ran on this pull request.

  • Detected categories: jwt, payment card
  • Replaced with typed [REDACTED:category] placeholders in: no PR metadata fields
  • Comment/review owners notified because X Engineering Agent cannot edit another user's text: ShawnX (@ShawnXxy), Ethan Yang (@necusjz)

X Engineering Agent does not modify source files. The PR creator must remove or replace each suspected value at the linked line:

  • No changed-file findings

If a credential was exposed, rotate or revoke it immediately. Detected values are never copied into this comment.

✅ Confirm the finding · ❌ Dispute the finding

GitHub only supports a fixed reaction set, so 👍 represents ✅ and 👎 represents ❌. The bot-created reactions are only poll choices.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot do-not-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants