[ACR] az acr create/encryption rotate-key: Add managed HSM key guidance - #34118
Merged
Merged
Conversation
…M key guidance Clarify that customer-managed encryption accepts Azure Key Vault and Managed HSM key URIs, add creation and rotation examples, and protect URI pass-through behavior with focused tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Hi Andrew Au (@cshung), |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
Bin Du (northtyphoon) and
Terence Truong (terencet-dev)
September 23, 2026 02:39
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
|
Thank you for your contribution Andrew Au (@cshung)! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Clarifies ACR customer-managed encryption key support for Azure Key Vault and Managed HSM URIs.
Changes:
- Updates command guidance and examples.
- Adds Managed HSM creation and rotation examples.
- Adds URI preservation tests.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/acr/tests/latest/test_acr_encryption.py |
Tests versioned and versionless Managed HSM URI handling. |
src/azure-cli/azure/cli/command_modules/acr/_params.py |
Updates argument guidance. |
src/azure-cli/azure/cli/command_modules/acr/_help.py |
Adds Managed HSM documentation and examples. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Julie Zhu (yanzhudd)
changed the title
az acr create, az acr encryption rotate-key: Add Managed HSM key guidanceaz acr create/encryption rotate-key: Add managed HSM key guidance
Julie Zhu (yanzhudd)
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Related command
az acr createaz acr encryption rotate-keyDescription
Clarify that
--key-encryption-keyaccepts Azure Key Vault and Managed HSM key URIs.Add examples for creating an ACR registry with a Managed HSM key and rotating an existing customer-managed encryption key. Add focused tests verifying that versioned and versionless Managed HSM URIs are passed to the ACR resource provider unchanged.
This PR does not change runtime behavior or add client-side endpoint validation. The ACR resource provider remains the authoritative validator, preserving compatibility with newly supported Azure clouds and endpoints.
Testing Guide
azdev linter acr --ci-exclusions.azdev style acr.