{Compute} az sig wait: Fix sig wait missing arg issue - #34128
Merged
Merged
Conversation
|
Hi William (@william051200), |
microsoft-github-policy-service
Bot
requested review from
Julie Zhu (yanzhudd) and
Yong Zhang (yonzhan)
September 24, 2026 07:20
Copilot started reviewing on behalf of
William (william051200)
September 24, 2026 07:20
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Implementation and tests are covered; the remaining metadata mismatch is a non-blocking nit.
Review effort: Lite
Findings: None
What changed in this PR
Restores missing query-argument handling for az sig share wait and adds scenario coverage with a recording.
Changes:
- Restores
$expandand$selecthandling with defaultPermissions. - Adds end-to-end scenario coverage and API recording.
| File | Summary |
|---|---|
src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py |
Adds sig share wait scenario coverage. |
src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_sig_share_wait.yaml |
Records expected API interactions. |
src/azure-cli/azure/cli/command_modules/vm/operations/sig_share.py |
Restores wait-command query handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Julie Zhu (yanzhudd)
approved these changes
Sep 24, 2026
Member
Author
|
Ethan Yang (@necusjz) yes, this is the fix for that issue |
Member
Author
|
/azp run |
Collaborator
|
Please fix CI issues |
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Related command
az sig waitDescription
The arg is missing after generated latest aaz code. Adding it back.
Testing Guide
test_sig_share_waitunder vm moduleHistory Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.