Skip to content

[Backup] az backup container register: Revert managed identity support for Azure Files backup - #34142

Merged
Ethan Yang (necusjz) merged 1 commit into
devfrom
revert-34109-users/bharatpurwar/afsmsi
Sep 29, 2026
Merged

Ethan Yang (necusjz) merged 1 commit into
devfrom
revert-34109-users/bharatpurwar/afsmsi

Conversation

@necusjz

Copy link
Copy Markdown
Member

Reverts #34109

Copilot AI balanced review requested due to automatic review settings September 29, 2026 03:35
@necusjz
Ethan Yang (necusjz) requested a review from a team as a code owner September 29, 2026 03:36
@yonzhan

Copy link
Copy Markdown
Collaborator

Thank you for your contribution! We will review the pull request and get back to you soon.

@necusjz
Ethan Yang (necusjz) merged commit 701a232 into dev Sep 29, 2026
15 of 73 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The implementation consistently reverts the command surface, behavior, documentation, and associated tests from #34109.

Review effort: Balanced
Findings: None

What changed in this PR

Reverts #34109, restoring the previous Azure Files backup behavior.

Changes:

  • Removes managed-identity registration, protection, and restore support.
  • Removes cross-subscription Azure Files restore support.
  • Removes associated parameters, help examples, formatting, and tests.
File Description
_client_factory.py Restores subscription-context client factories.
_format.py Removes identity fields from container output.
_help.py Removes reverted feature examples.
_params.py Removes managed-identity and cross-subscription arguments.
commands.py Restores the workload registration handler.
custom_afs.py Restores prior registration and restore behavior.
custom_base.py Removes routing and parameters for reverted functionality.
test_afs_commands.py Removes the managed-identity scenario test.
test_custom_afs.py Removes feature-specific unit tests.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@yonzhan

Copy link
Copy Markdown
Collaborator

Backup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants