[AppService] Fix #33732: az webapp show: Restore appServicePlanId in output - #34149
Open
Shreyas Gopalakrishna (shreyas-gopalakrishna) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Shreyas Gopalakrishna (shreyas-gopalakrishna)
requested a review
from a team
as a code owner
September 29, 2026 18:27
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
Yu Chen (jsntcy),
ZelinWang (wangzelin007),
Julie Zhu (yanzhudd) and
Yong Zhang (yonzhan)
September 29, 2026 18:29
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation addresses both reported regressions with focused compatibility coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Restores established App Service Plan identifiers in AppService command output and prevents table-formatting failures.
Changes:
- Normalizes serialized Site models for Web, Function, and Logic Apps.
- Safely handles missing plan IDs.
- Adds unit and scenario coverage.
| File | Description |
|---|---|
appservice/commands.py |
Adds output normalization and safe table formatting. |
tests/latest/test_webapp_commands.py |
Verifies Web App list/show output compatibility. |
tests/latest/test_webapp_commands_thru_mock.py |
Tests model serialization and missing-plan behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 34149 in repo Azure/azure-cli |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Member
Author
|
Aditya Pujara (@a0x1ab) Yong Zhang (@yonzhan) could you review this PR |
Collaborator
|
Please fix CI issues |
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 34149 in repo Azure/azure-cli |
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az webapp showaz webapp listaz functionapp list --output tableDescription
Fixes #33732
Fixes #33914
Supersedes #33733.
azure-mgmt-web11.0.0 changedSitemodels to TypeSpec-generated hybrid models. Adding an undeclaredapp_service_plan_idattribute no longer affects CLI serialization, soaz webapp show/listexposedserverFarmIdinstead of the establishedappServicePlanIdfield. The missing field also caused table formatting to raiseKeyErrorfor affected Function App responses.This change:
Sitemodels before normalizing their output.appServicePlanIdis present andserverFarmIdis removed fromaz webapp show/list.appServicePlanIdwhile retainingserverFarmIdfor Function App and Logic App compatibility.Testing Guide
Local validation:
azdev style appserviceazdev linter appservicegit diff --checkHistory Notes
[AppService]
az webapp show/list: RestoreappServicePlanIdin output[AppService]
az functionapp list --output table: Handle apps without an App Service Plan IDThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.